Merged
Conversation
getEnvRaw: `getEnvRaw` is essentially the same as `getEnv`, but much more safe as it doesn't automatically convert types - parsing is left to the consuming code. parseBool: `parseBool` is a much more accepting function for parsing booleans. `true`, `1`, `yes`, and `on` are treated as `true`, and conversely, `false`, `0`, `no`, and `off` are treated as `false`.
proxyAttachments: `proxyAttachments` is the equivalent of `DIRECT_RESPONSE_ATTACHMENT`. [...file].ts: Replaced direct usage of `getEnv` with new config system.
forcePathStyle: Added missing field of `forcePathStyle`. proxyAttachments: Added documentation for `proxyAttachments`.
server: The `server` field will just contain things related to the server. I dunno how to explain it, but it's for that. useSecureCookies: `server.useSecureCookies` is the equivalent of `COOKIE_SECURE`. config/compatibility.yml: Add documentation for the new `server` field.
deprecation: Well, it is. `getEnv` is too direct. It's not really a good system.
config/compatibility.yml: Updated the example to reflect how the config actually works. move-to-server: It feels nicer to have it inside the `server` field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is mostly internal but does entail two user-facing change;
server.server.useSecureCookies, which is the equivalent ofCOOKIE_SECURE.baseUrlhas been moved toserver.baseUrl. See config/compatibility.ymlInternal changes:
getEnv, and marked the function as deprecated.getEnvRawis used to access the variables; it only gives you a string, and never anything else.parseBoolparses booleans from strings.true,1,yes, andonare treated astruewhilstfalse,0,no, andoffare treated asfalse.