feat: show emoji in title as tree icon instead#118
Merged
QingWei-Li merged 2 commits intonotea-org:mainfrom Oct 29, 2021
Merged
feat: show emoji in title as tree icon instead#118QingWei-Li merged 2 commits intonotea-org:mainfrom
QingWei-Li merged 2 commits intonotea-org:mainfrom
Conversation
Collaborator
|
I like it. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @QingWei-Li ! Definitely no pressure to merge this one. I personally prefer it this way, but I agree this might not be something everyone wants. In that case, you can close it and I'll just use it in my private fork 🙂
Preview
Current logic: If the title contains a single emoji (doesn't matter where) it will be placed instead of the right/down chevron in the tree: