Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Sep 10, 2024

Golang introduced go toolchain since go v1.21: https://tip.golang.org/doc/toolchain#version. Some of the notation-go dependencies have started to use it, for example golang/mod. However, this caused notation-go dependabot failed to bump up: #454.

This PR fixes this issue by updating the golang version to v1.22.0 and bumping up golang/mod as a test.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.98%. Comparing base (4d76f9a) to head (f9f4d79).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #457   +/-   ##
=======================================
  Coverage   80.98%   80.98%           
=======================================
  Files          33       33           
  Lines        2487     2487           
=======================================
  Hits         2014     2014           
  Misses        331      331           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 694e3a0 into notaryproject:main Sep 10, 2024
@ghost ghost deleted the bump branch September 10, 2024 05:37
@ghost ghost mentioned this pull request Sep 27, 2024
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants