refactor!: update revocation based on notation-core-go #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 30, 2024 12:38
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
ghost
requested review from
JeyJeyGao,
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
==========================================
+ Coverage 80.74% 80.86% +0.12%
==========================================
Files 33 33
Lines 2457 2483 +26
==========================================
+ Hits 1984 2008 +24
- Misses 331 332 +1
- Partials 142 143 +1 ☔ View full report in Codecov by Sentry. |
ghost
mentioned this pull request
JeyJeyGao
reviewed
Aug 6, 2024
shizhMSFT
reviewed
Aug 6, 2024
added 2 commits
August 6, 2024 16:50
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Aug 6, 2024
added 4 commits
August 7, 2024 08:19
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
rgnote
reviewed
Aug 9, 2024
ghost
mentioned this pull request
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This was referenced Aug 13, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes refactoring of revocation with the updated notation-core-go.