Skip to content

Conversation

@toddysm
Copy link
Contributor

@toddysm toddysm commented Apr 1, 2024

toddysm and others added 4 commits January 11, 2024 11:22
ghost
ghost previously approved these changes Apr 1, 2024
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi previously approved these changes Apr 2, 2024
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
@toddysm toddysm dismissed stale reviews from priteshbandi and ghost via f51578f April 2, 2024 00:58
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.04%. Comparing base (9ff1891) to head (a54779b).
Report is 12 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   73.43%   76.04%   +2.60%     
==========================================
  Files          24       30       +6     
  Lines        2507     2158     -349     
==========================================
- Hits         1841     1641     -200     
+ Misses        526      371     -155     
- Partials      140      146       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddysm toddysm merged commit 2d65f6e into notaryproject:main Apr 4, 2024
JeyJeyGao pushed a commit that referenced this pull request May 29, 2024
Addressing notaryproject/.github#66 and
notaryproject/.github#68 also addressed
notaryproject/.github#67 and
notaryproject/.github#69

---------

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
This was referenced May 29, 2024
@ghost ghost mentioned this pull request Jul 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants