Skip to content

Robustify per_samplify #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SamDuffield merged 1 commit into from
Apr 24, 2024
Merged

Robustify per_samplify #79

SamDuffield merged 1 commit into from
Apr 24, 2024

Conversation

@SamDuffield
Copy link
Contributor

@SamDuffield SamDuffield commented Apr 24, 2024

Fix discussed in #78

The wrapper enforces no kwargs when the vmap is called and therefore in_dims works as expected e.g. when used with partial

@SamDuffield SamDuffield marked this pull request as ready for review April 24, 2024 14:21
@SamDuffield SamDuffield requested a review from KaelanDt April 24, 2024 14:21
KaelanDt
KaelanDt reviewed Apr 24, 2024
View reviewed changes
@SamDuffield SamDuffield merged commit 21f8c7f into main Apr 24, 2024
@SamDuffield SamDuffield deleted the fix-per-samplify branch April 24, 2024 15:59
@SamDuffield SamDuffield mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@KaelanDt KaelanDt KaelanDt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SamDuffield @KaelanDt