Skip to content

Fix reversed primary interactive colors in light/dark modes#759

Merged
gmacev merged 2 commits intomasterfrom
fix-colors-mismatch
Nov 6, 2025
Merged

Fix reversed primary interactive colors in light/dark modes#759
gmacev merged 2 commits intomasterfrom
fix-colors-mismatch

Conversation

@gmacev
Copy link
Contributor

@gmacev gmacev commented Nov 4, 2025

What

  • What was done in this Pull Request

    • Swapped primary interactive color values between light and dark modes, as they were clearly reversed by mistake.
    • Fixed linkInverse color in dark mode to properly contrast with regular link color
  • How was it before

    • Light mode used dark blue colors (appearing way too dark)
    • Dark mode used light grey colors (appearing way too light)
  • Screenshots

  • Any other information that may be useful for the dev to review Pull Request

Testing

  • Is this change covered by the unit tests?

  • Is this change covered by the integration tests?

  • Is this change covered by the automated acceptance tests? (if applicable)

Compatibility

  • Does this change maintain backward compatibility?

Screenshots

Before

After

…t and dark modes

The primary interactive colors (primary, primaryHover, primaryActive) were
incorrectly swapped between light and dark modes. Light mode was using dark
blue colors while dark mode was using light grey colors, causing visibility
and contrast issues.

Changes:
- Light mode: now uses grey.grey500/600/700 for primary states
- Dark mode: now uses darkBlue.darkBlue500/700/800 for primary states
- Fixed linkInverse in dark mode to use deepBlue500 instead of deepBlue200
@gmacev gmacev self-assigned this Nov 4, 2025
@gmacev gmacev requested a review from a team as a code owner November 4, 2025 15:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2025

@gmacev gmacev merged commit a9ea6ec into master Nov 6, 2025
5 of 7 checks passed
@gmacev gmacev deleted the fix-colors-mismatch branch November 6, 2025 14:13
@gmacev gmacev mentioned this pull request Nov 25, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants