[v22.x] src: use std::sort in node_metadata for libc++13 compatibility#61789
Open
rebroad wants to merge 1 commit intonodejs:v22.x-stagingfrom
Open
[v22.x] src: use std::sort in node_metadata for libc++13 compatibility#61789rebroad wants to merge 1 commit intonodejs:v22.x-stagingfrom
rebroad wants to merge 1 commit intonodejs:v22.x-stagingfrom
Conversation
addaleax
approved these changes
Feb 12, 2026
Member
|
Would be nice to add a note about why this doesn't affect 24.x and above in the commit message, though |
Collaborator
lpinca
approved these changes
Feb 12, 2026
dfff7a1 to
f1670c5
Compare
Author
I've not looked at 24.x, so it might also affect that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces
std::ranges::sort()withstd::sort(begin, end, ...)insrc/node_metadata.cc.Motivation
On armhf + clang-13/libc++13,
std::ranges::sortis unavailable, causing Node v22 build failure.Testing
make -j2Notes