test: fix timing issue in signal test #1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Much better. LGTM. |
Change sequential/test-signal-unregister so it doesn't use fixed timeouts for sending the signal and expecting the child to quit. Fixes: nodejs#1223 PR-URL: nodejs#1227 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Move sequential/test-signal-unregister to test/parallel, it doesn't need to run in sequential mode. PR-URL: nodejs#1227 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
bnoordhuis
force-pushed
the
fix-issue-1223
branch
from
a595d53 to
9705a34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change sequential/test-signal-unregister so it doesn't use fixed
timeouts for sending the signal and expecting the child to quit.
Fixes: #1223
R=@jbergstroem
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/355/