Skip to content

Conversation

@alexcfyung
Copy link
Contributor

Allow gyp to build shared libraries such as .x file on z/OS. This is needed to enable node.js to build shared library on z/OS.

Copy link

@AdNaN-rK AdNaN-rK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@AdNaN-rK AdNaN-rK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reqes change

Copy link

@AdNaN-rK AdNaN-rK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Copy link

@AdNaN-rK AdNaN-rK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review changes

Copy link

@AdNaN-rK AdNaN-rK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review changes

Copy link

@AdNaN-rK AdNaN-rK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes

@zsw007
Copy link

zsw007 commented Mar 28, 2022

Request changes

Hi, could you please clarify what changes are requested?

Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM, someone please merge if this works as intended.

@targos targos merged commit 293bcfa into nodejs:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants