Skip to content

Conversation

@tunnckoCore
Copy link
Member

fixes #994

Signed-off-by: tunnckoCore <5038030+tunnckoCore@users.noreply.github.com>
Signed-off-by: tunnckoCore <5038030+tunnckoCore@users.noreply.github.com>
Signed-off-by: tunnckoCore <5038030+tunnckoCore@users.noreply.github.com>
Signed-off-by: tunnckoCore <5038030+tunnckoCore@users.noreply.github.com>
Signed-off-by: tunnckoCore <5038030+tunnckoCore@users.noreply.github.com>
Signed-off-by: tunnckoCore <5038030+tunnckoCore@users.noreply.github.com>
Signed-off-by: tunnckoCore <5038030+tunnckoCore@users.noreply.github.com>
Signed-off-by: tunnckoCore <5038030+tunnckoCore@users.noreply.github.com>
@tunnckoCore tunnckoCore requested a review from Copilot April 23, 2025 01:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fix issue #994 by removing the problematic os.machine() call from the fingerprint string while also updating CI/CD node versions and changelog entries.

  • Removed os.machine() from the CUID2_FINGERPRINT string in src/Formidable.js.
  • Updated the node-version matrix in the GitHub Actions workflow.
  • Updated the changelog with fixes and additional CI support.

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/Formidable.js Removed the os.machine() call, but an extra curly bracket remains.
CHANGELOG.md Updated changelog to document the removal and CI/CD changes.
.github/workflows/main.yml Expanded the node-version matrix to include specific Node.js versions.
Files not reviewed (2)
  • package.json: Language not supported
  • pnpm-lock.yaml: Language not supported

@tunnckoCore tunnckoCore requested a review from Copilot April 23, 2025 01:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #994 by removing the use of os.machine from the fingerprint generation in Formidable.js and updates the CI configuration for Node.js versions.

  • Remove os.machine from the CUID2 fingerprint string in Formidable.js.
  • Update CHANGELOG to document the fix and additional Node.js version support.
  • Update the GitHub workflow matrix with new Node.js versions.

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/Formidable.js Removed os.machine from CUID2 fingerprint; check extra brace in the string template
CHANGELOG.md Updated changelog to reflect the fix and new CI versions
.github/workflows/main.yml Updated node-version matrix with additional Node.js versions
Files not reviewed (2)
  • package.json: Language not supported
  • pnpm-lock.yaml: Language not supported

import { json, multipart, octetstream, querystring } from './plugins/index.js';

const CUID2_FINGERPRINT = `${process.env.NODE_ENV}-${os.platform()}-${os.hostname()}-${os.machine()}`
const CUID2_FINGERPRINT = `${process.env.NODE_ENV}-${os.platform()}-${os.hostname()}}`
Copy link

Copilot AI Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated string template for CUID2_FINGERPRINT contains an extra '}' at the end after os.hostname(). Removing the extra '}' should correctly format the fingerprint string.

Suggested change
const CUID2_FINGERPRINT = `${process.env.NODE_ENV}-${os.platform()}-${os.hostname()}}`
const CUID2_FINGERPRINT = `${process.env.NODE_ENV}-${os.platform()}-${os.hostname()}`

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@tunnckoCore tunnckoCore requested a review from Copilot April 23, 2025 01:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the usage of os.machine from the CUID2 fingerprint computation to address issue #994 and updates the changelog and CI configuration accordingly.

  • Removed os.machine from the fingerprint constant in src/Formidable.js.
  • Updated the CHANGELOG to document the fix and added newer Node versions to CI.
  • Expanded the Node version matrix in GitHub workflows.

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
src/Formidable.js Removed usage of os.machine in CUID2_FINGERPRINT construction.
CHANGELOG.md Updated changelog entries to document the fix and new Node versions.
.github/workflows/main.yml Updated Node version matrix to include versions 18, 20, and 22 along with lts/*.
Files not reviewed (2)
  • package.json: Language not supported
  • pnpm-lock.yaml: Language not supported

@tunnckoCore tunnckoCore merged commit b2483ba into master Apr 23, 2025
18 checks passed
@tunnckoCore tunnckoCore deleted the fix-os-machine branch April 23, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.1.3 is not compatible with node@16, but 2.1.2 is ok

2 participants