Fix a bug, queuedText is not handled in reset#169
Merged
tjvr merged 1 commit intono-context:masterfrom Mar 26, 2022
Merged
Conversation
hikerpig
force-pushed
the
bugfix/reset-queuedText
branch
from
ce4a33d to
7df2a0c
Compare
tjvr
approved these changes
Mar 26, 2022
Collaborator
tjvr
left a comment
tjvr
left a comment
There was a problem hiding this comment.
I think you're right. Thanks for this! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my project when using Nearley.js and moo.js together, after multiple times of parsing, sometimes the parser would throw an error.
I find that is due to moo.js, when it resets, the
queuedTextis not handled.I think when it comes to reset and save,
queuedTextshould be no different thanqueuedToken.