improve error message for push

fixes warp-drive-dataGH-2201

Author: Stanley Stuart

packages/ember-data/lib/system/store.js

@@ -1293,8 +1293,8 @@ Store = Ember.Object.extend({
     // _partial is an internal param used by `update`.
     // If passed, it means that the data should be
     // merged into the existing data, not replace it.
-
-    Ember.assert("You must include an `id` for " + typeName+ " in a hash passed to `push`", data.id != null);
+    Ember.assert("Expected an object as `data` in a call to push for " + typeName + " , but was " + data, Ember.typeOf(data) === 'object');
+    Ember.assert("You must include an `id` for " + typeName + " in an object passed to `push`", data.id != null);
 
     var type = this.modelFor(typeName);
 

packages/ember-data/tests/unit/store/push_test.js

@@ -316,3 +316,23 @@ test("Calling pushPayload without a type should use a model's serializer when no
 
   equal(person.get('firstName'), "Yehuda", "you can push raw JSON into the store");
 });
+
+test('calling push without data argument as an object raises an error', function(){
+  var invalidValues = [
+    undefined,
+    null,
+    1,
+    'string',
+    Ember.Object.create(),
+    Ember.Object.extend(),
+    true
+  ];
+
+  expect(invalidValues.length);
+
+  Ember.EnumerableUtils.forEach(invalidValues, function(invalidValue){
+    throws(function(){
+      store.push('person', invalidValue);
+    }, /object/);
+  });
+});