Merge pull request warp-drive-data#2215 from emberjs/unused-vars-jshint

remove unused variables and enforce in jshint

Author: fivetanley

.jshintrc

@@ -61,5 +61,6 @@
     "strict": false,
     "white": false,
     "eqnull": true,
-    "esnext": true
+    "esnext": true,
+    "unused": "vars"
 }

packages/activemodel-adapter/lib/system/active_model_adapter.js

@@ -1,7 +1,6 @@
 import {RESTAdapter} from "ember-data/adapters";
 import {InvalidError} from "ember-data/system/adapter";
 import {pluralize} from "ember-inflector";
-import ActiveModelSerializer from "activemodel-adapter/system/active_model_serializer";
 
 /**
   @module ember-data

packages/ember-data/lib/main.js

@@ -80,13 +80,15 @@ DS.RootState = RootState;
 DS.attr      = attr;
 DS.Errors    = Errors;
 
-DS.AttributeChange       = AttributeChange;
-DS.RelationshipChange    = RelationshipChange;
-DS.RelationshipChangeAdd = RelationshipChangeAdd;
-DS.OneToManyChange       = OneToManyChange;
-DS.ManyToNoneChange      = OneToManyChange;
-DS.OneToOneChange        = OneToOneChange;
-DS.ManyToManyChange      = ManyToManyChange;
+DS.AttributeChange          = AttributeChange;
+DS.RelationshipChange       = RelationshipChange;
+DS.RelationshipChangeAdd    = RelationshipChangeAdd;
+DS.RelationshipChangeRemove = RelationshipChangeRemove;
+DS.ManyToNoneChange         = ManyToNoneChange;
+DS.OneToManyChange          = OneToManyChange;
+DS.ManyToNoneChange         = OneToManyChange;
+DS.OneToOneChange           = OneToOneChange;
+DS.ManyToManyChange         = ManyToManyChange;
 
 DS.Adapter      = Adapter;
 DS.InvalidError = InvalidError;

packages/ember-data/lib/serializers/embedded_records_mixin.js

@@ -2,8 +2,6 @@ var get = Ember.get;
 var forEach = Ember.EnumerableUtils.forEach;
 var camelize = Ember.String.camelize;
 
-import {pluralize} from "ember-inflector";
-
 /**
   ## Using Embedded Records
 
@@ -181,7 +179,6 @@ var EmbeddedRecordsMixin = Ember.Mixin.create({
   */
   serializeBelongsTo: function(record, json, relationship) {
     var attr = relationship.key;
-    var attrs = this.get('attrs');
     if (this.noSerializeOptionSpecified(attr)) {
       this._super(record, json, relationship);
       return;
@@ -291,7 +288,6 @@ var EmbeddedRecordsMixin = Ember.Mixin.create({
   */
   serializeHasMany: function(record, json, relationship) {
     var attr = relationship.key;
-    var attrs = this.get('attrs');
     if (this.noSerializeOptionSpecified(attr)) {
       this._super(record, json, relationship);
       return;
@@ -366,8 +362,6 @@ var EmbeddedRecordsMixin = Ember.Mixin.create({
   // checks config for attrs option to serialize records
   noSerializeOptionSpecified: function(attr) {
     var option = this.attrsOption(attr);
-    var serializeRecords = this.hasSerializeRecordsOption(attr);
-    var serializeIds = this.hasSerializeIdsOption(attr);
     return !(option && (option.serialize || option.embedded));
   },
 

packages/ember-data/lib/serializers/json_serializer.js

@@ -1,6 +1,5 @@
 import { RelationshipChange } from "ember-data/system/changes";
 var get = Ember.get;
-var set = Ember.set;
 var isNone = Ember.isNone;
 var map = Ember.ArrayPolyfills.map;
 var merge = Ember.merge;
@@ -196,7 +195,7 @@ export default Ember.Object.extend({
     @private
   */
   normalizeAttributes: function(type, hash) {
-    var payloadKey, key;
+    var payloadKey;
 
     if (this.keyForAttribute) {
       type.eachAttribute(function(key) {
@@ -215,7 +214,7 @@ export default Ember.Object.extend({
     @private
   */
   normalizeRelationships: function(type, hash) {
-    var payloadKey, key;
+    var payloadKey;
 
     if (this.keyForRelationship) {
       type.eachRelationship(function(key, relationship) {

packages/ember-data/lib/serializers/rest_serializer.js

@@ -4,7 +4,6 @@
 
 import JSONSerializer from "ember-data/serializers/json_serializer";
 var get = Ember.get;
-var set = Ember.set;
 var forEach = Ember.ArrayPolyfills.forEach;
 var map = Ember.ArrayPolyfills.map;
 var camelize = Ember.String.camelize;

packages/ember-data/lib/system/adapter.js

@@ -3,8 +3,6 @@
 */
 
 var get = Ember.get;
-var set = Ember.set;
-var map = Ember.ArrayPolyfills.map;
 
 var errorProps = [
   'description',

packages/ember-data/lib/system/container_proxy.js

@@ -36,7 +36,7 @@ ContainerProxy.prototype.registerDeprecation = function(deprecated, valid) {
 };
 
 ContainerProxy.prototype.registerDeprecations = function(proxyPairs) {
-  var i, proxyPair, deprecated, valid, proxy;
+  var i, proxyPair, deprecated, valid;
 
   for (i = proxyPairs.length; i > 0; i--) {
     proxyPair = proxyPairs[i - 1];

packages/ember-data/lib/system/model/states.js

@@ -173,18 +173,6 @@ var set = Ember.set;
   @class RootState
 */
 
-function hasDefinedProperties(object) {
-  // Ignore internal property defined by simulated `Ember.create`.
-  var names = Ember.keys(object);
-  var i, l, name;
-  for (i = 0, l = names.length; i < l; i++ ) {
-    name = names[i];
-    if (object.hasOwnProperty(name) && object[name]) { return true; }
-  }
-
-  return false;
-}
-
 function didSetProperty(record, context) {
   if (context.value === context.originalValue) {
     delete record._attributes[context.name];
@@ -259,12 +247,8 @@ var DirtyState = {
     loadingData: Ember.K,
 
     propertyWasReset: function(record, name) {
-      var stillDirty = false;
-
-      for (var prop in record._attributes) {
-        stillDirty = true;
-        break;
-      }
+      var length = Ember.keys(record._attributes);
+      var stillDirty = length > 0;
 
       if (!stillDirty) { record.send('rolledBack'); }
     },

packages/ember-data/lib/system/record_array_manager.js

@@ -9,7 +9,6 @@ import {
   ManyArray
 } from "ember-data/system/record_arrays";
 var get = Ember.get;
-var set = Ember.set;
 var forEach = Ember.EnumerableUtils.forEach;
 
 /**