This repository was archived by the owner on Feb 27, 2019. It is now read-only.
Defines a callback for the notifications permission#207
Open
dominikweifieg wants to merge 2 commits intonickoneill:masterfrom
Open
Defines a callback for the notifications permission#207dominikweifieg wants to merge 2 commits intonickoneill:masterfrom
dominikweifieg wants to merge 2 commits intonickoneill:masterfrom
Conversation
Owner
|
Thanks @dominikweifieg, this sounds reasonable. Can you add this to the docs as well? |
Author
|
Sure, will do so tomorrow morning my time and add it to the pull request. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using frameworks like PushWoosh or OneSignal, the app has to call methods on these frameworks to request the permission for notifications from iOS. Since PermissionScope calls UIApplication.shared.registerUserNotificationSettings itself, it is not possible to use PermissionScope and, e.g., OneSignal together in an integrated way.
I have added a notificationRequestCallback which, if set, will be called instead of UIApplication.shared.registerUserNotificationSettings in requestNotifications