docs(store): deprecate createFeatureSelector with root state#3190
Merged
markostanimirovic merged 1 commit intongrx:masterfrom Oct 20, 2021
santoshyadavdev:master
Merged
docs(store): deprecate createFeatureSelector with root state#3190markostanimirovic merged 1 commit intongrx:masterfrom santoshyadavdev:master
markostanimirovic merged 1 commit intongrx:masterfrom
santoshyadavdev:master
Conversation
Contributor
Author
|
Hi @timdeschryver should I add the migrations as well I can see you have a eslint rule timdeschryver/eslint-plugin-ngrx#155 I can reuse the code from here |
Collaborator
|
Preview docs changes for a83195e at https://previews.ngrx.io/pr3190-a83195e8/ |
Member
|
@santoshyadavdev , you can add the migration if you want (as a separate commit, or in another PR). |
Contributor
Author
Cool will raise another PR once I am back from vacation, I mean I can get some idea from the lint. |
timdeschryver
approved these changes
Oct 19, 2021
markostanimirovic
approved these changes
Oct 20, 2021
This was referenced Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3179
What is the new behavior?
Does this PR introduce a breaking change?
Other information