refactor(store): use Record as Store generic#3158
Merged
brandonroberts merged 3 commits intomasterfrom Oct 5, 2021
Merged
Conversation
Collaborator
|
Preview docs changes for 0092dd1 at https://previews.ngrx.io/pr3158-0092dd10/ |
markostanimirovic
approved these changes
Oct 1, 2021
brandonroberts
approved these changes
Oct 5, 2021
timdeschryver
added a commit
that referenced
this pull request
Oct 22, 2021
This reverts commit 605fd02.
brandonroberts
pushed a commit
that referenced
this pull request
Oct 23, 2021
This was referenced Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information
This change should help for cases as #2780 (comment).
This change doesn't fix the cases where
createFeatureSelectoris used with 2 generics.To resolve those cases, we could assert the generic
Tasany, or remove the<State, FeatureState>overload fromcreateFeatureSelectorin the next version.