16bit work staging #591
Merged
16bit work staging #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add remap function into create_sidd_structure
update remape after pytest work this was tricky on the github web page
fixing test for changing signature for bit depth option
Clean up remap get regerstered logic
clean up dead dict
addjust parameter ordering in calls to sidd_product_create
update parameter order for create_sidd_structure as mentioned in second code review for 16 bit work
some joz clean up and parameter order adjustmest from second code review for 16 bit work
correct test to match new signature
style changes
add some tests around 16 bit remapping
test to make sure remap bit depth in allowed values 8 or 16
petersontex
approved these changes
Jul 11, 2025
Collaborator
petersontex
left a comment
petersontex
left a comment
There was a problem hiding this comment.
The team reviewed this code submission and agrees to all changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uhmm, i think this is right. My changes from 16bit_work_staging branch to staging branch off master repo.