Skip to content

Conversation

@brianhendee
Copy link
Contributor

When performing a SICD write, Sarpy stores the data in an array, then creates a bytes object from that array. That takes time, and increases the memory footprint. This modifies the logic to create a view into the stored array instead of a copy. It also allows memory mapping to be explicitly turned on and off. This prevents sarpy from attempting to use memory mapping on systems that don't support it.

@petersontex petersontex changed the base branch from master to optimize-file-write June 13, 2025 14:14
@petersontex
Copy link
Collaborator

@brianhendee Thank you for your code submission. We are reviewing the code and determining when to integrate it. We are also writing test cases to ensure proper integration.

@petersontex petersontex merged commit e0edb5f into ngageoint:optimize-file-write Jun 18, 2025
@petersontex
Copy link
Collaborator

@brianhendee I am reviewing your code for integration into a sarpy release. How did you envision users activating this enhancement? It appears to me that users set all the parameters used with the NITFWriter in the NITFWritingDetails class. What do you think of moving the in_memory parameter into the NITFWritingDetails class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants