Added RCM ScanSAR SICD converter #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for creating SICDs from RCM ScanSAR collects. One SICD is created per burst. This implementation is intended to minimize the impacts to the RADARSAT-2 and non-ScanSAR RCM code paths, while trying to avoid too much code duplication. All of the ScanSAR specific logic was placed in
rcm_scansar.py, andradarsat.pywas refactored to allow parts of it to be reused.RadarSatDetailshas been refactored to have two base classes,RSDetailsandRSCdp, which get used byrcm_scansar.py'sRcmScanSarDetailsandRcmScanSarCdprespectively.We took the path of isolating RCM ScanSAR because it was our imperative to not change the RS2 and non-ScanSAR RCM results, as we had no unit tests to judge any changes' acceptability. We have performed regression testing with RS2 and non-ScanSAR RCM datasets and verified there are no changes to their SICD conversions.
It may be possible to further combine
radarsat.pyandrcm_scansar.py, but doing so would require a more comprehensive analysis of the RS2 and RCM modes and formats and may result in changes to the non-ScanSAR SICD conversion results.An example RCM ScanSAR dataset can be found at CSA's OpenData FTP site: ftp://ftp.asc-csa.gc.ca/users/OpenData_DonneesOuvertes/pub/RCM/Antarctica/