Skip to content

move scripts + remove public_aws_ecr profile#205

Merged
drpatelh merged 2 commits intonf-core:devfrom
maxulysse:move_files
Sep 22, 2023
Merged

move scripts + remove public_aws_ecr profile#205
drpatelh merged 2 commits intonf-core:devfrom
maxulysse:move_files

Conversation

@maxulysse
Copy link
Member

@maxulysse maxulysse commented Sep 22, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/fetchngs branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse maxulysse marked this pull request as ready for review September 22, 2023 10:01
@github-actions
Copy link

github-actions bot commented Sep 22, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a86f54f

+| ✅ 148 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   5 tests had warnings |!
Details

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • files_exist - File not found: lib/WorkflowFetchngs.groovy
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-22 10:37:29

@maxulysse maxulysse changed the title move scripts move scripts + remove public_aws_ecr profile Sep 22, 2023
drpatelh
drpatelh approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@drpatelh drpatelh merged commit de39ec1 into nf-core:dev Sep 22, 2023
@maxulysse maxulysse deleted the move_files branch September 22, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxulysse @drpatelh