fix: toolbar buttons disappear on window resize #882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Custom toolbar buttons disappear on toolbar re-render (e.g. when Excalidraw changes to mobile).
The hooks used reference guards to prevent duplicate button insertion. When Excalidraw rebuilt the toolbar these still held stale references to removed buttons, blocking re-insertion. Additionally, each hook implemented its own rendering logic.
Solution
ToolbarButtoncomponent to handle the custom toolbar button renderingMutationObserverto watch for Excalidraw class changes and re-render buttons automaticallyuseEmojiPicker,useSmartPicker,useTableInsertion,useAssistant,useComment) to use the centralized component