Merged
Conversation
artonge
added
enhancement
artonge
force-pushed
the
artonge/feat/use_etag_as_cache_buster
branch
from
55d9e0b to
2ebb46f
Compare
artonge
force-pushed
the
artonge/feat/use_etag_as_cache_buster
branch
from
2ebb46f to
2f5d64b
Compare
Contributor
Author
|
/backport to stable27 |
Contributor
Author
|
/backport to stable26 |
backportbot-nextcloud
bot
added
the
backport-request
Contributor
Author
|
/backport to stable25 |
artonge
requested review from
a team,
Pytal and
szaimen
and removed request for
a team
szaimen
reviewed
Jun 8, 2023
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
✅ LGTM from the screenshots :)
skjnldsv
reviewed
Jun 8, 2023
artonge
force-pushed
the
artonge/feat/use_etag_as_cache_buster
branch
4 times, most recently
from
4dbe731 to
64ce3fa
Compare
Contributor
Author
|
@skjnldsv if you have the time to review this 🙏 |
skjnldsv
reviewed
Jun 20, 2023
3 tasks
artonge
force-pushed
the
artonge/feat/use_etag_as_cache_buster
branch
from
64ce3fa to
f4ed250
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/feat/use_etag_as_cache_buster
branch
from
f4ed250 to
3d36a9c
Compare
skjnldsv
approved these changes
Jun 27, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #1554 to cover more usecases.
I reverted #1554 and added the etag to the preview URL to prevent cache mismatch.
One thing is that I am doing a new PROPFIND request. I am wondering if we should do it where the event is emitted instead of where it is received, because listeners will probably always need some form of updated information.