Skip to content

HTML entities in video filenames are decoded before sending request #2095

@iw0nderhow

Description

@iw0nderhow

Describe the bug
I can't view any videos with filenames containing HTML entities, e.g. &.

To Reproduce
Steps to reproduce the behavior:

  1. Upload a video.
  2. Rename it to &.mp4.
  3. Open it
  4. Doesn't work

Expected behavior
The video opens.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
Firefox 120, macOS 14. Nextcloud 27.1.4.

Browser log

[INFO] viewer: Opening viewer for file  
Object { app: "viewer", uid: "christopher", level: 0, path: "/Downloads/Archiv/&.mp4" }
ConsoleLogger.js:53:18
File info for /Downloads/Archiv/&.mp4 fetched 
Object { filename: "/Downloads/Archiv/&.mp4", basename: "&.mp4", lastmod: "Wed, 06 Dec 2023 19:30:44 GMT", size: 20766733, type: "file", etag: "20da2f45465bb77c597cfd0b65fd6533", mime: "video/mp4", getlastmodified: "Wed, 06 Dec 2023 19:30:44 GMT", getcontenttype: "video/mp4", resourcetype: "", … }
Viewer.vue:608
Error loading /Downloads/Archiv/&.mp4 
error { target: div.plyr.plyr--full-ui.plyr--video.plyr--html5.plyr--fullscreen-enabled.plyr--paused.plyr--stopped, isTrusted: false, detail: {…}, srcElement: div.plyr.plyr--full-ui.plyr--video.plyr--html5.plyr--fullscreen-enabled.plyr--paused.plyr--stopped, currentTarget: div.viewer__file.viewer__file--active, eventPhase: 3, bubbles: true, cancelable: false, returnValue: true, defaultPrevented: false, … }
Mime.js:140:11

Additional context
Add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    0. Needs triagePending approval or rejection. This issue is pending approval.bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions