fix(menubar): Add aria-selected and aria-activedescendant to menu bar items (fix #3911)#4888
Merged
juliusknorr merged 1 commit intomainfrom Oct 20, 2023
Merged
fix(menubar): Add aria-selected and aria-activedescendant to menu bar items (fix #3911)#4888juliusknorr merged 1 commit intomainfrom
juliusknorr merged 1 commit intomainfrom
Conversation
juliusknorr
force-pushed
the
a11y/toolbar2
branch
from
b2252bb to
34141eb
Compare
juliusknorr
requested review from
luka-nextcloud,
max-nextcloud,
mejo- and
susnux
skjnldsv
approved these changes
Oct 20, 2023
susnux
previously requested changes
Oct 20, 2023
src/components/Menu/ActionList.vue
Outdated
| v-bind="state" | ||
| :container="menuIDSelector" | ||
| :aria-label="actionEntry.label" | ||
| :aria-activedescendant="!!currentChild" |
Contributor
There was a problem hiding this comment.
This should not be a boolean value, but the ID of the currently active (focused) element.
Contributor
There was a problem hiding this comment.
Meaning this should be set on the menu toggle with the value of the active action button in the popover
Member
Author
There was a problem hiding this comment.
Right, seems I mixed that up, will have a look
Member
Author
There was a problem hiding this comment.
Adjusted to have a unique id matching with the menu entries.
… items (fix #3911) Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
a11y/toolbar2
branch
from
34141eb to
15ae86a
Compare
susnux
approved these changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes #3911
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)