tests(cypress): Refactor reconnect test to be more reliable and add second test for actual reconnect#4507
Conversation
2 flaky tests on run #11073 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Hard break support > Do not create hard breaks within headings |
Output
Screenshots
|
|
api/UsersApi.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| The user mention API > fetches users with valid session |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
juliusknorr
force-pushed
the
cypress/reconnect-test
branch
from
70339f9 to
652080a
Compare
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Awesome, thanks for tackling this ✨
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Yay! Thanks for getting to the bottom of this! 🤿
Also great idea to test the close / create loop.
I have just one small remark.
cypress/e2e/sync.spec.js
Outdated
| if (reconnect) { | ||
| req.continue() | ||
| req.alias = 'alive' | ||
| reconnect = true |
There was a problem hiding this comment.
This seems somewhat redundant as reconnect is already checked to be truethy in line 70
Or am I missing something?
There was a problem hiding this comment.
Right, seems I've left this from the other test where the toggle re-enable connections is triggered by the close/connect
|
Maybe also backport to stable27... and stable26 |
|
/backport to stable27 |
|
/backport to stable26 |
…econd test for actual reconnect Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
cypress/reconnect-test
branch
from
652080a to
712f54a
Compare
3 participants
This should make our top failure cypress test on main more reliable and also extends it with another case: