DirectEditing: Set session user for DirectSession editing#3356
DirectEditing: Set session user for DirectSession editing#3356max-nextcloud merged 2 commits intomasterfrom
Conversation
marcelklehr
requested review from
a team,
juliusknorr and
max-nextcloud
and removed request for
a team
|
Not sure if this is the best approach. Advice is welcome :) |
to have it available for the file put activities event fixes nextcloud/android#10237 fixes #2821 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
fix/no-user-in-file-put-event
branch
from
c566b6f to
468f4e3
Compare
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Seems like a good approach 👍
|
The failing cypress test was about fetching a preview for a |
|
Since this was reported with NC 22 i think it will require backports. I'll try and trigger them. |
|
/backport to stable25 |
|
/backport to stable24 |
|
/backport to stable23 |
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Code looks good. Did not test it though.
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
|
Same test failed again - but this really does not look like a related issue. Will merge anyway. |
3 participants
fixes nextcloud/android#10237
fixes #2821
Summary
Set session user for DirectSession editing to have it available for the file put activities event