Merged
Conversation
…allback to media if previewManager does not support them Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Member
|
Wouldn't the mimetypes also need to be added to |
Member
Author
Thanks for the fast review. |
Member
|
Ah, makes sense. Thanks for the explanation 👍 |
mejo-
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small change is actually enough to support HEIC/HEIF files as image attachments.
This requires to have ImageMagic and the php-imagick module installed and the relevant preview providers enabled.
To enable the providers, one would need to have that in config.php:
If the providers are not enabled, heic/heif files are considered as media attachment.