feat: treat tasks with STATUS:COMPLETED as completed
#2429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how a task is identified as completed. If one interprets RFC5545 very strictly, the
COMPLETEDproperty needs to be present in order for a task to be completed. However, e.g. Homeassistant seems to only setSTATUStoCOMPLETEDand misses settingCOMPLETED:20240101T100142Zas well. We now treat tasks withSTATUS:COMPLETEDas completed, similar to how we treat tasks withSTATUS:CANCELLED.However, this is only an adjustment here. E.g. Nextcloud server only handles tasks with
COMPLETEDproperty as completed. But as this is an edge case, I think we can live with the different interpretation. Nonetheless, this should be fixed in Homeassistant!Closes #2428.