Don't provide props via navigating #2218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2218 +/- ##
============================================
- Coverage 28.65% 27.13% -1.52%
============================================
Files 69 60 -9
Lines 3033 2915 -118
Branches 733 738 +5
============================================
- Hits 869 791 -78
+ Misses 2164 2124 -40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
paramsthat are not defined on thepathwill break with vue-router 4.1.4, since it's an anti-pattern. See https://github.com/vuejs/router/blob/main/packages/router/CHANGELOG.md#important-note.So we don't do this anymore and instead open the tab via an emitted event after the
AppSidebarwas mounted.