Closed
Conversation
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
Codecov Report
@@ Coverage Diff @@
## master #5638 +/- ##
============================================
- Coverage 53.81% 7.29% -46.52%
- Complexity 22668 22784 +116
============================================
Files 1404 1408 +4
Lines 86643 86344 -299
Branches 1328 1328
============================================
- Hits 46625 6302 -40323
- Misses 40018 80042 +40024
|
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
|
Hi @daita . Let me understand this PR. Is the Circles' payload going to save the new share in oc_dav_shares table locally? |
Member
|
@daita What is the status of this? You opened a PR with very few descriptions and it looks abandoned. Either we try to get this in or close it. If you need feedback then we should get the people in for reviews. ;) |
Member
Author
|
let's close this, i will come back later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.