fix(files_sharing): Password field must not be required if already set#48991
Merged
fix(files_sharing): Password field must not be required if already set#48991
Conversation
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
susnux
force-pushed
the
fix/password-field-sharing
branch
from
2c8b26f to
f984570
Compare
If there is already a password, there is no need to require the password
in the setting ('newPassword'). It is only required for new shares.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/password-field-sharing
branch
from
f984570 to
e13b6d3
Compare
nfebe
approved these changes
Oct 30, 2024
Contributor
nfebe
left a comment
nfebe
left a comment
There was a problem hiding this comment.
LGTM.
Wondering what would happen if someone attempts to remove password on an existing share, if possible.
provokateurin
approved these changes
Oct 30, 2024
Contributor
Author
If the password is enforced, then this is not possible, you can only modify it. |
This was referenced Oct 30, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is already a password, there is no need to require the password in the setting ('newPassword'). It is only required for new shares.
Checklist