fix: Allow overriding shouldApplyQuota check from child classes#48623
Merged
provokateurin merged 1 commit intomasterfrom Oct 9, 2024
Merged
fix: Allow overriding shouldApplyQuota check from child classes#48623provokateurin merged 1 commit intomasterfrom
provokateurin merged 1 commit intomasterfrom
Conversation
Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorr
requested review from
artonge,
come-nc,
icewind1991 and
provokateurin
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
provokateurin
approved these changes
Oct 9, 2024
artonge
approved these changes
Oct 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While not the cleanest, since it is a private class, groupfolders currently extends from the Quota class, so we need to be able to adjust the behaviour of shouldApplyQuota
Checklist