Skip to content

fix: Show storage full warning when storage is actually full#48354

Merged
artonge merged 1 commit intomasterfrom
artonge/fix/storage_full_warning
Sep 26, 2024
Merged

fix: Show storage full warning when storage is actually full#48354
artonge merged 1 commit intomasterfrom
artonge/fix/storage_full_warning

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Sep 25, 2024 •
edited
Loading

< 0 values for "free" do not mean that the storage is full:

server/lib/public/Files/FileInfo.php

Lines 27 to 41 in 6befdd6

/**
* @const \OCP\Files\FileInfo::SPACE_NOT_COMPUTED Return value for a not computed space value
* @since 8.0.0
*/
public const SPACE_NOT_COMPUTED = -1;
/**
* @const \OCP\Files\FileInfo::SPACE_UNKNOWN Return value for unknown space value
* @since 8.0.0
*/
public const SPACE_UNKNOWN = -2;
/**
* @const \OCP\Files\FileInfo::SPACE_UNLIMITED Return value for unlimited space
* @since 8.0.0
*/
public const SPACE_UNLIMITED = -3;

Signed-off-by: Louis Chemineau louis@chmn.me

  • Resolves: #

Summary

TODO

  • ...

Checklist

@artonge artonge requested a review from skjnldsv as a code owner September 25, 2024 11:54
@artonge artonge self-assigned this Sep 25, 2024
@artonge artonge requested a review from susnux September 25, 2024 11:54
@artonge artonge added this to the Nextcloud 31 milestone Sep 25, 2024
@artonge
Copy link
Contributor Author

artonge commented Sep 25, 2024

/backport to stable28

@artonge
Copy link
Contributor Author

artonge commented Sep 25, 2024

/backport to stable29

@artonge
Copy link
Contributor Author

artonge commented Sep 25, 2024

/backport to stable30

@artonge artonge force-pushed the artonge/fix/storage_full_warning branch from cb2bc91 to 1046f8d Compare September 25, 2024 15:48
@artonge
Copy link
Contributor Author

artonge commented Sep 25, 2024

/compile amend /

@artonge artonge enabled auto-merge September 25, 2024 15:48
@nextcloud-command nextcloud-command force-pushed the artonge/fix/storage_full_warning branch from 1046f8d to ee03123 Compare September 25, 2024 15:56
@artonge

This comment was marked as duplicate.

Sign in to view
@artonge

This comment was marked as duplicate.

Sign in to view
@artonge

This comment was marked as duplicate.

Sign in to view
@artonge
fix: Show storage full warning when storage is actually full
d576efb 
< 0 values for "free" do not mean that the storage is full: https://github.com/nextcloud/server/blob/6befdd6dd7cd20fe7f7036e4665bcfbb783d6803/lib/public/Files/FileInfo.php#L31-L42

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge artonge force-pushed the artonge/fix/storage_full_warning branch from ee03123 to d576efb Compare September 25, 2024 17:42
@artonge artonge merged commit 098f3c1 into master Sep 26, 2024
@artonge artonge deleted the artonge/fix/storage_full_warning branch September 26, 2024 08:38
This was referenced Sep 26, 2024
Merged
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@provokateurin provokateurin provokateurin approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees

@artonge artonge

Labels

3. to review Waiting for reviews bug feature: files javascript

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

3 participants

@artonge @susnux @provokateurin