fix(files): Only execute default action if there is an action to perform#45586
Merged
fix(files): Only execute default action if there is an action to perform#45586
Conversation
Contributor
Author
|
/backport to stable28 |
Contributor
Author
|
/backport to stable29 |
artonge
approved these changes
Jun 4, 2024
Some files do not have a default action (can not be viewed and only downloaded). If the `openfile` query is set on them the `handleOpenFile` will throw an error. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/files-default-action
branch
from
cffed68 to
d33cfdd
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsv
approved these changes
Jun 4, 2024
skjnldsv
added
4. to release
This was referenced Jun 4, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some files do not have a default action (can not be viewed and only downloaded). If the
openfilequery is set on them thehandleOpenFilewill throw an error.Checklist