Skip to content

#42647 fix(file settings): Unnecessary 2FA UI message (updated) #44594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JED-B wants to merge 6 commits into from
Closed

#42647 fix(file settings): Unnecessary 2FA UI message (updated) #44594

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cef1f22
fix(file settings): get rid of Unnecessary 2FA UI message
JED-B Apr 1, 2024
dc7ff6f
Merge branch 'master' into Fix#42647
JED-B Apr 1, 2024
9e1cc06
Merge branch 'master' into Fix#42647
JED-B Apr 2, 2024
28ee87b
Merge branch 'master' into Fix#42647
JED-B Apr 2, 2024
dca36da
Merge branch 'master' into Fix#42647
JED-B Apr 2, 2024
455c9cf
Merge branch 'master' into Fix#42647
JED-B Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions apps/files/src/views/Settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<!--
- @copyright Copyright (c) 2023 John Molakvoæ <skjnldsv@protonmail.com>
- @copyright Copyright (c) 2024 Jed Boulahya <jed.boulahya@medtech.tn>
-
- @author John Molakvoæ <skjnldsv@protonmail.com>
-
Expand Down Expand Up @@ -88,11 +89,14 @@
</a>
</em>
<br>
<em>
<a class="setting-link" :href="appPasswordUrl">
{{ t('files', 'If you have enabled 2FA, you must create and use a new app password by clicking here.') }} ↗
</a>
</em>
<!-- Conditional rendering based on 2FA -->
<template v-if="isTwoFactorEnabled">
Copy link
Member

@skjnldsv skjnldsv Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable doesn't exist?
You need to check of we have a capability for it or else inject the variables from the Controller yourself :)

<em>
<a class="setting-link" :href="appPasswordUrl">
{{ t('files', 'If you have enabled 2FA, you must create and use a new app password by clicking here.') }} ↗
</a>
</em>
</template>
</NcAppSettingsSection>
</NcAppSettingsDialog>
</template>
Expand Down