Use the proper path to check if a file needs to be copied/moved to the actual target storage#43983
Merged
icewind1991 merged 1 commit intomasterfrom Mar 8, 2024
Merged
Conversation
juliusknorr
force-pushed
the
fix/s3-upload-shared-lock
branch
from
0cbe485 to
794eee8
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
fix/s3-upload-shared-lock
branch
from
794eee8 to
ca453f5
Compare
juliusknorr
requested review from
a team,
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
juliusknorr
added
3. to review
juliusknorr
changed the title
juliusknorr
changed the title
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
artonge
changed the title
artonge
approved these changes
Mar 8, 2024
icewind1991
approved these changes
Mar 8, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves issues where after an s3 multipart upload we run into issues with shared locks while trying to copy as we're actually copying the file to the same path again.
Confirmed to fix issues where a file upload >10MB caused conflicting shared lock issues during the MOVE of chunked upload parts.