fix(provisioning_api): Fix AppInfo schema for OpenAPI#43877
Merged
provokateurin merged 1 commit intomasterfrom Mar 14, 2024
Merged
fix(provisioning_api): Fix AppInfo schema for OpenAPI#43877provokateurin merged 1 commit intomasterfrom
provokateurin merged 1 commit intomasterfrom
Conversation
provokateurin
requested review from
andrey18106,
bigcat88,
come-nc and
nickvergessen
Member
Author
|
/backport to stable28 |
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/provisioning_api/app-info-schema
branch
from
2799db1 to
0565583
Compare
andrey18106
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There are a few mistakes in the current schema (e.g. multiple language support for name, description and summary). Instead of trying to fix those problems I opted for generalizing the whole schema as the provided type information was mostly useless anyway (values typed as
?mixed). This could have also led to problems in case the XSD was updated and this schema wasn't, so this avoids it. The real problem is that the AppStore data is simply passed through without any checking for any structure, but that can't be fixed easily.Checklist