allow admin to disable lookupserver upload#4250
Merged
Conversation
schiessle
changed the title
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
…rofile picture' Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
schiessle
force-pushed
the
disable-lookupserver-upload
branch
from
92d77b7 to
d5173ac
Compare
ChristophWurst
requested changes
Apr 10, 2017
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
some nitpicks, the rest looks good though
| */ | ||
| public function isLookupServerUploadEnabled() { | ||
| $result = $this->config->getAppValue('files_sharing', 'lookupServerUploadEnabled', 'yes'); | ||
| return ($result === 'yes') ? true : false; |
Member
There was a problem hiding this comment.
the ($result === 'yes') part already results in a proper boolean value, no need for the ternary operator here 😉
We could even shorten this to
return $this->config->getAppValue('files_sharing', 'lookupServerUploadEnabled', 'yes') === 'yes';
Member
Author
There was a problem hiding this comment.
completely right, that's happen if you copy&paste methods and only replace the relevant parts 😉
I will not do the last step you suggested because I think this makes it harder to debug but will simplify the return statement
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
ChristophWurst
approved these changes
Apr 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the admin to disable the possibility to publish user specific data on the lookup server.
fixes the "turn off showing phone number, address, WWW, Twitter" part of #3821
cc @KB7777