Merged
Conversation
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
emoral435
force-pushed
the
fix/remove-unnecessary-checks
branch
from
c11b55f to
24f97a5
Compare
Contributor
Author
|
/backport to stable28 |
nickvergessen
approved these changes
Dec 19, 2023
Comment on lines
-1576
to
-1578
| $passwordProtected = $share->getShareType() !== IShare::TYPE_LINK | ||
| || $share->getShareType() !== IShare::TYPE_EMAIL | ||
| || $share->getShareType() !== IShare::TYPE_CIRCLE; |
Member
There was a problem hiding this comment.
What a weird code section. The value can never be all 3 of the constants... so this is always true?
I tracked it back until c191173#diff-6c825986578290fe355bffe05c5232629a36e554d48f5d889bb2c1ec73645265R1113-R1114 and there it was already wrong.
So, nice find.
come-nc
approved these changes
Dec 19, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves #32373
🚧 Summary
After looking through the codebase, what the piece of code was doing before was just checking the type of sharing that the file had enabled. This leaves up to question - does it directly impact the password settings that the other checks do not do?
So, here's what the check did - and why I removed it
As the type of shares being used lets the user dictate if there is a password or not, the other checks in place are more useful towards checking if there is a password on the shared object.
Checklist