Conversation
susnux
requested review from
a team,
AndyScherzinger,
JuliaKirschenheuter,
Pytal,
ShGKme,
emoral435 and
sorbaugh
and removed request for
a team
susnux
force-pushed
the
chore/update-vue
branch
from
ee590b5 to
af102d9
Compare
ShGKme
approved these changes
Nov 17, 2023
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/update-vue
branch
from
af102d9 to
9b9133c
Compare
AndyScherzinger
approved these changes
Nov 17, 2023
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
ShGKme
reviewed
Nov 17, 2023
Comment on lines
+42
to
+50
| cy.get('li[data-cy-settings-new-group-name]').within(() => { | ||
| // see that the group name is "" | ||
| cy.get('input[placeholder="Group name"]').should('exist').and('have.value', '') | ||
| cy.get('input').should('exist').and('have.value', '') | ||
| // set the group name to foo | ||
| cy.get('input[placeholder="Group name"]').type(groupName) | ||
| cy.get('input').type(groupName) | ||
| // see that the group name is foo | ||
| cy.get('input[placeholder="Group name"]').should('have.value', groupName) | ||
| cy.get('input').should('have.value', groupName) | ||
| // submit the group name | ||
| cy.get('input[placeholder="Group name"] ~ button').click() | ||
| cy.get('input ~ button').click() |
Contributor
There was a problem hiding this comment.
To fix the test, only removing [role="menu"] seems to be required. Then there is no need in data-cy attribute, which uses test less semantic and more coupled on implementation (manually marked place).
Contributor
Author
There was a problem hiding this comment.
It would depend on internal implementation (class action-item__popper) which is bad.
So this flags the action where to look on a non implementation dependent way (we set the attribute in our code so we do not rely on the implementation of the action, except for the li element but this is required due to a bug with actions (the attribute will be assigned on the li tag and also forwarded to the input tag).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Required for accessibility.
Checklist