Skip to content

Show a setup warning in case S3 object storage is used as primary storage#14603

Merged
MorrisJobke merged 1 commit intomasterfrom
fix/noid/add-setup-check-for-s3-temp-path
Mar 8, 2019
Merged

Show a setup warning in case S3 object storage is used as primary storage#14603
MorrisJobke merged 1 commit intomasterfrom
fix/noid/add-setup-check-for-s3-temp-path

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 8, 2019

  • checks for at least 50 GB of free space

As discussed @rullzer

@MorrisJobke
Show a setup warning in case S3 object storage is used as primary sto…
060b637 
…rage

* checks for at least 50 GB of free space

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 8, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Mar 8, 2019
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 8, 2019

/backport to stable15

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 8, 2019

/backport to stable14

@faily-bot
Copy link

faily-bot bot commented Mar 8, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16884: failure

DB=mysql, ENABLE_REDIS=false, PHP=7.3

Show full log 
There was 1 failure:

1) TrashbinTest::testExpireOldFiles
Failed asserting that null is identical to 'file2.txt'.

/drone/src/github.com/nextcloud/server/apps/files_trashbin/tests/TrashbinTest.php:186

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

DB=mysqlmb4, ENABLE_REDIS=false, PHP=7.3

Show full log 
There was 1 failure:

1) TrashbinTest::testExpireOldFiles
Failed asserting that null is identical to 'file2.txt'.

/drone/src/github.com/nextcloud/server/apps/files_trashbin/tests/TrashbinTest.php:186

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

TESTS=integration-federation_features

  • build/integration/federation_features/federated.feature:183
  • build/integration/federation_features/federated.feature:232
  • build/integration/federation_features/federated.feature:247
  • build/integration/federation_features/federated.feature:263
Show full log 
[Fri Mar  8 13:35:15 2019] 127.0.0.1:39220 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Fri Mar  8 13:35:15 2019] 127.0.0.1:39234 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Reshare a federated shared file                                                             # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:183
    Given Using server "REMOTE"                                                                         # FederationContext::usingServer()
[Fri Mar  8 13:35:15 2019] 127.0.0.1:47606 [404]: /ocs/v2.php/cloud/users/user1
[Fri Mar  8 13:35:15 2019] 127.0.0.1:47622 [200]: /ocs/v1.php/cloud/users
[Fri Mar  8 13:35:16 2019] 127.0.0.1:47664 [200]: /ocs/v1.php/cloud/users/user1
[Fri Mar  8 13:35:16 2019] 127.0.0.1:47710 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                             # FederationContext::assureUserExists()
[Fri Mar  8 13:35:16 2019] 127.0.0.1:47722 [404]: /ocs/v2.php/cloud/users/user2
[Fri Mar  8 13:35:16 2019] 127.0.0.1:47730 [200]: /ocs/v1.php/cloud/users
[Fri Mar  8 13:35:18 2019] 127.0.0.1:47760 [200]: /ocs/v1.php/cloud/users/user2
[Fri Mar  8 13:35:18 2019] 127.0.0.1:47846 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                             # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                            # FederationContext::usingServer()
[Fri Mar  8 13:35:18 2019] 127.0.0.1:39494 [404]: /ocs/v2.php/cloud/users/user0
[Fri Mar  8 13:35:18 2019] 127.0.0.1:39502 [200]: /ocs/v1.php/cloud/users
[Fri Mar  8 13:35:19 2019] 127.0.0.1:39524 [200]: /ocs/v1.php/cloud/users/user0
[Fri Mar  8 13:35:19 2019] 127.0.0.1:39560 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                             # FederationContext::assureUserExists()
[Fri Mar  8 13:35:19 2019] 127.0.0.1:47956 [200]: /ocm-provider/
[Fri Mar  8 13:35:19 2019] 127.0.0.1:47962 [201]: /index.php/ocm/shares
[Fri Mar  8 13:35:19 2019] 127.0.0.1:39576 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/textfile0.txt" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Fri Mar  8 13:35:19 2019] 127.0.0.1:47966 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Fri Mar  8 13:35:20 2019] 127.0.0.1:39628 [200]: //ocm-provider/
[Fri Mar  8 13:35:20 2019] 127.0.0.1:39630 [201]: /index.php/ocm/notifications
[Fri Mar  8 13:35:20 2019] 127.0.0.1:39634 [200]: //ocs-provider/
[Fri Mar  8 13:35:20 2019] 127.0.0.1:39636 [200]: /ocs/v2.php/cloud/shares/8/accept?format=json
[Fri Mar  8 13:35:20 2019] 127.0.0.1:47980 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/9
    And User "user1" from server "REMOTE" accepts last pending share                                    # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                           # FederationContext::usingServer()
    And As an "user1"                                                                                   # FederationContext::asAn()
[Fri Mar  8 13:35:20 2019] 127.0.0.1:39648 [200]: //ocs-provider/
[Fri Mar  8 13:35:20 2019] 127.0.0.1:39652 [200]: //status.php
[Fri Mar  8 13:35:20 2019] 127.0.0.1:39656 [200]: //status.php
[Fri Mar  8 13:35:20 2019] 127.0.0.1:39658 [200]: /index.php/apps/files_sharing/shareinfo?t=6DPIFHqoipWeS9z
[Fri Mar  8 13:35:20 2019] 127.0.0.1:48000 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    When creating a share with                                                                          # FederationContext::creatingShare()
      | path        | /textfile0 (2).txt |
      | shareType   | 0                  |
      | shareWith   | user2              |
      | permissions | 19                 |
    Then the OCS status code should be "100"                                                            # FederationContext::theOCSStatusCodeShouldBe()
      Failed asserting that SimpleXMLElement Object &000000003c7f2344000000007196e426 (
          0 => '404'
      ) matches expected '100'.
    And the HTTP status code should be "200"                                                            # FederationContext::theHTTPStatusCodeShouldBe()
    And Share fields of last share match with                                                           # FederationContext::checkShareFields()
      | id                     | A_NUMBER           |
      | item_type              | file               |
      | item_source            | A_NUMBER           |
      | share_type             | 0                  |
      | file_source            | A_NUMBER           |
      | path                   | /textfile0 (2).txt |
      | permissions            | 19                 |
      | stime                  | A_NUMBER           |
      | storage                | A_NUMBER           |
      | mail_send              | 1                  |
      | uid_owner              | user1              |
      | file_parent            | A_NUMBER           |
      | displayname_owner      | user1              |
      | share_with             | user2              |
      | share_with_displayname | user2              |
[Fri Mar  8 13:35:20 2019] 127.0.0.1:39660 [200]: /ocs/v1.php/cloud/users/user0
[Fri Mar  8 13:35:21 2019] 127.0.0.1:39690 [404]: /ocs/v2.php/cloud/users/user0
[Fri Mar  8 13:35:21 2019] 127.0.0.1:39724 [200]: //ocm-provider/
[Fri Mar  8 13:35:21 2019] 127.0.0.1:39726 [400]: /index.php/ocm/notifications
[Fri Mar  8 13:35:21 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 8"}

[Fri Mar  8 13:35:31 2019] 127.0.0.1:40372 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Fri Mar  8 13:35:31 2019] 127.0.0.1:40396 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared folder as recipient                                             # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:232
    Given Using server "REMOTE"                                                                          # FederationContext::usingServer()
[Fri Mar  8 13:35:31 2019] 127.0.0.1:48758 [404]: /ocs/v2.php/cloud/users/user1
[Fri Mar  8 13:35:31 2019] 127.0.0.1:48764 [200]: /ocs/v1.php/cloud/users
[Fri Mar  8 13:35:32 2019] 127.0.0.1:48780 [200]: /ocs/v1.php/cloud/users/user1
[Fri Mar  8 13:35:32 2019] 127.0.0.1:48794 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                              # FederationContext::assureUserExists()
[Fri Mar  8 13:35:32 2019] 127.0.0.1:48796 [404]: /ocs/v2.php/cloud/users/user2
[Fri Mar  8 13:35:32 2019] 127.0.0.1:48798 [200]: /ocs/v1.php/cloud/users
[Fri Mar  8 13:35:33 2019] 127.0.0.1:48814 [200]: /ocs/v1.php/cloud/users/user2
[Fri Mar  8 13:35:33 2019] 127.0.0.1:48828 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                              # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                             # FederationContext::usingServer()
[Fri Mar  8 13:35:33 2019] 127.0.0.1:40476 [404]: /ocs/v2.php/cloud/users/user0
[Fri Mar  8 13:35:35 2019] 127.0.0.1:40480 [200]: /ocs/v1.php/cloud/users
[Fri Mar  8 13:35:36 2019] 127.0.0.1:40494 [200]: /ocs/v1.php/cloud/users/user0
[Fri Mar  8 13:35:36 2019] 127.0.0.1:40516 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                              # FederationContext::assureUserExists()
[Fri Mar  8 13:35:36 2019] 127.0.0.1:48886 [200]: /ocm-provider/
[Fri Mar  8 13:35:36 2019] 127.0.0.1:48888 [201]: /index.php/ocm/shares
[Fri Mar  8 13:35:36 2019] 127.0.0.1:40524 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/PARENT" with user "user1" from server "REMOTE"         # FederationContext::federateSharing()
[Fri Mar  8 13:35:36 2019] 127.0.0.1:48890 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Fri Mar  8 13:35:37 2019] 127.0.0.1:40542 [200]: //ocm-provider/
[Fri Mar  8 13:35:37 2019] 127.0.0.1:40544 [201]: /index.php/ocm/notifications
[Fri Mar  8 13:35:37 2019] 127.0.0.1:40546 [200]: //ocs-provider/
[Fri Mar  8 13:35:37 2019] 127.0.0.1:40548 [200]: /ocs/v2.php/cloud/shares/10/accept?format=json
[Fri Mar  8 13:35:37 2019] 127.0.0.1:48896 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/11
    And User "user1" from server "REMOTE" accepts last pending share                                     # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                            # FederationContext::usingServer()
    And As an "user1"                                                                                    # FederationContext::asAn()
    And User "user1" modifies text of "/textfile0.txt" with text "BLABLABLA"                             # FederationContext::modifyTextOfFile()
[Fri Mar  8 13:35:37 2019] 127.0.0.1:40568 [200]: //ocs-provider/
[Fri Mar  8 13:35:37 2019] 127.0.0.1:40570 [401]: /public.php/webdav/textfile0.txt
[Fri Mar  8 13:35:37 2019] 127.0.0.1:40572 [404]: /public.php/webdav/textfile0.txt
[Fri Mar  8 13:35:37 2019] 127.0.0.1:40574 [200]: //status.php
[Fri Mar  8 13:35:37 2019] 127.0.0.1:40576 [200]: //status.php
[Fri Mar  8 13:35:37 2019] 127.0.0.1:40578 [200]: /index.php/apps/files_sharing/shareinfo?t=Y92DT2uIPgKbgwV
[Fri Mar  8 13:35:37 2019] Undefined index: size at /drone/src/github.com/nextcloud/server/lib/private/Files/View.php#1324
[Fri Mar  8 13:35:37 2019] Undefined index: storage_mtime at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#126
[Fri Mar  8 13:35:37 2019] 127.0.0.1:40584 [207]: /public.php/webdav/
[Fri Mar  8 13:35:37 2019] Undefined index: etag at /drone/src/github.com/nextcloud/server/lib/private/Files/Storage/DAV.php#784
[Fri Mar  8 13:35:37 2019] 127.0.0.1:40586 [200]: //status.php
[Fri Mar  8 13:35:37 2019] 127.0.0.1:40588 [200]: //status.php
[Fri Mar  8 13:35:37 2019] 127.0.0.1:40594 [200]: /index.php/apps/files_sharing/shareinfo?t=Y92DT2uIPgKbgwV
[Fri Mar  8 13:35:37 2019] Undefined index: mimetype at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#108
[Fri Mar  8 13:35:37 2019] 127.0.0.1:48926 [404]: /remote.php/webdav/PARENT%20(2)/textfile0.txt
    When User "user1" uploads file "../../data/user1/files/textfile0.txt" to "/PARENT (2)/textfile0.txt" # FederationContext::userUploadsAFileTo()
      Client error: `PUT http://localhost:8180/remote.php/webdav/PARENT%20(2)/textfile0.txt` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And Downloading file "/PARENT (2)/textfile0.txt" with range "bytes=0-8"                              # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "BLABLABLA"                                                        # FederationContext::downloadedContentShouldBe()
[Fri Mar  8 13:35:38 2019] 127.0.0.1:40596 [200]: /ocs/v1.php/cloud/users/user0
[Fri Mar  8 13:35:38 2019] 127.0.0.1:40626 [404]: /ocs/v2.php/cloud/users/user0
[Fri Mar  8 13:35:44 2019] 127.0.0.1:40678 [200]: //ocm-provider/
[Fri Mar  8 13:35:44 2019] 127.0.0.1:40680 [400]: /index.php/ocm/notifications
[Fri Mar  8 13:35:44 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 10"}

[Fri Mar  8 13:35:47 2019] 127.0.0.1:40770 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Fri Mar  8 13:35:47 2019] 127.0.0.1:40776 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared file as recipient using old chunking                           # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:247
    Given Using server "REMOTE"                                                                         # FederationContext::usingServer()
[Fri Mar  8 13:35:47 2019] 127.0.0.1:49144 [404]: /ocs/v2.php/cloud/users/user1
[Fri Mar  8 13:35:47 2019] 127.0.0.1:49154 [200]: /ocs/v1.php/cloud/users
[Fri Mar  8 13:35:53 2019] 127.0.0.1:49192 [200]: /ocs/v1.php/cloud/users/user1
[Fri Mar  8 13:35:53 2019] 127.0.0.1:49616 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                             # FederationContext::assureUserExists()
[Fri Mar  8 13:35:54 2019] 127.0.0.1:49636 [404]: /ocs/v2.php/cloud/users/user2
[Fri Mar  8 13:35:57 2019] 127.0.0.1:49654 [200]: /ocs/v1.php/cloud/users
[Fri Mar  8 13:35:57 2019] 127.0.0.1:49862 [200]: /ocs/v1.php/cloud/users/user2
[Fri Mar  8 13:35:58 2019] 127.0.0.1:49912 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                             # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                            # FederationContext::usingServer()
[Fri Mar  8 13:35:58 2019] 127.0.0.1:41566 [404]: /ocs/v2.php/cloud/users/user0
[Fri Mar  8 13:35:58 2019] 127.0.0.1:41576 [200]: /ocs/v1.php/cloud/users
[Fri Mar  8 13:35:58 2019] 127.0.0.1:41596 [200]: /ocs/v1.php/cloud/users/user0
[Fri Mar  8 13:35:58 2019] 127.0.0.1:41630 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                             # FederationContext::assureUserExists()
[Fri Mar  8 13:35:58 2019] 127.0.0.1:50006 [200]: /ocm-provider/
[Fri Mar  8 13:35:58 2019] 127.0.0.1:50008 [201]: /index.php/ocm/shares
[Fri Mar  8 13:35:58 2019] 127.0.0.1:41636 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/textfile0.txt" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Fri Mar  8 13:35:59 2019] 127.0.0.1:50012 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Fri Mar  8 13:35:59 2019] 127.0.0.1:41678 [200]: //ocm-provider/
[Fri Mar  8 13:35:59 2019] 127.0.0.1:41680 [201]: /index.php/ocm/notifications
[Fri Mar  8 13:35:59 2019] 127.0.0.1:41684 [200]: //ocs-provider/
[Fri Mar  8 13:35:59 2019] 127.0.0.1:41686 [200]: /ocs/v2.php/cloud/shares/11/accept?format=json
[Fri Mar  8 13:35:59 2019] 127.0.0.1:50024 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/12
    And User "user1" from server "REMOTE" accepts last pending share                                    # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                           # FederationContext::usingServer()
    And As an "user1"                                                                                   # FederationContext::asAn()
[Fri Mar  8 13:35:59 2019] 127.0.0.1:41708 [200]: //ocs-provider/
[Fri Mar  8 13:35:59 2019] 127.0.0.1:41710 [401]: /public.php/webdav/
[Fri Mar  8 13:35:59 2019] 127.0.0.1:41716 [207]: /public.php/webdav/
[Fri Mar  8 13:35:59 2019] 127.0.0.1:41728 [200]: //status.php
[Fri Mar  8 13:35:59 2019] 127.0.0.1:41732 [200]: //status.php
[Fri Mar  8 13:35:59 2019] 127.0.0.1:41738 [200]: /index.php/apps/files_sharing/shareinfo?t=fxzh8P0dknsvqMg
[Fri Mar  8 13:35:59 2019] 127.0.0.1:50056 [404]: /remote.php/webdav/textfile0%20(2).txt-chunking-42-3-0
    And user "user1" uploads chunk file "1" of "3" with "AAAAA" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
      Client error: `PUT http://localhost:8180/remote.php/webdav/textfile0%20(2).txt-chunking-42-3-0` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And user "user1" uploads chunk file "2" of "3" with "BBBBB" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    And user "user1" uploads chunk file "3" of "3" with "CCCCC" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    When Downloading file "/textfile0 (2).txt" with range "bytes=0-4"                                   # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "AAAAA"                                                           # FederationContext::downloadedContentShouldBe()
[Fri Mar  8 13:35:59 2019] 127.0.0.1:41746 [200]: /ocs/v1.php/cloud/users/user0
[Fri Mar  8 13:36:00 2019] 127.0.0.1:41800 [404]: /ocs/v2.php/cloud/users/user0
[Fri Mar  8 13:36:01 2019] 127.0.0.1:41926 [200]: //ocm-provider/
[Fri Mar  8 13:36:01 2019] 127.0.0.1:41930 [400]: /index.php/ocm/notifications
[Fri Mar  8 13:36:01 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 11"}

[Fri Mar  8 13:36:02 2019] 127.0.0.1:42022 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Fri Mar  8 13:36:03 2019] 127.0.0.1:42032 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared folder as recipient using old chunking                  # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:263
    Given Using server "REMOTE"                                                                  # FederationContext::usingServer()
[Fri Mar  8 13:36:03 2019] 127.0.0.1:50400 [404]: /ocs/v2.php/cloud/users/user1
[Fri Mar  8 13:36:03 2019] 127.0.0.1:50408 [200]: /ocs/v1.php/cloud/users
[Fri Mar  8 13:36:03 2019] 127.0.0.1:50428 [200]: /ocs/v1.php/cloud/users/user1
[Fri Mar  8 13:36:03 2019] 127.0.0.1:50460 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                      # FederationContext::assureUserExists()
[Fri Mar  8 13:36:04 2019] 127.0.0.1:50468 [404]: /ocs/v2.php/cloud/users/user2
[Fri Mar  8 13:36:04 2019] 127.0.0.1:50482 [200]: /ocs/v1.php/cloud/users
[Fri Mar  8 13:36:05 2019] 127.0.0.1:50516 [200]: /ocs/v1.php/cloud/users/user2
[Fri Mar  8 13:36:05 2019] 127.0.0.1:50580 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                      # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                     # FederationContext::usingServer()
[Fri Mar  8 13:36:05 2019] 127.0.0.1:42226 [404]: /ocs/v2.php/cloud/users/user0
[Fri Mar  8 13:36:05 2019] 127.0.0.1:42236 [200]: /ocs/v1.php/cloud/users
[Fri Mar  8 13:36:06 2019] 127.0.0.1:42256 [200]: /ocs/v1.php/cloud/users/user0
[Fri Mar  8 13:36:06 2019] 127.0.0.1:42280 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                      # FederationContext::assureUserExists()
[Fri Mar  8 13:36:06 2019] 127.0.0.1:50656 [200]: /ocm-provider/
[Fri Mar  8 13:36:06 2019] 127.0.0.1:50660 [201]: /index.php/ocm/shares
[Fri Mar  8 13:36:06 2019] 127.0.0.1:42290 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/PARENT" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Fri Mar  8 13:36:06 2019] 127.0.0.1:50662 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Fri Mar  8 13:36:06 2019] 127.0.0.1:42322 [200]: //ocm-provider/
[Fri Mar  8 13:36:06 2019] 127.0.0.1:42324 [201]: /index.php/ocm/notifications
[Fri Mar  8 13:36:06 2019] 127.0.0.1:42330 [200]: //ocs-provider/
[Fri Mar  8 13:36:06 2019] 127.0.0.1:42334 [200]: /ocs/v2.php/cloud/shares/12/accept?format=json
[Fri Mar  8 13:36:06 2019] 127.0.0.1:50674 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/13
    And User "user1" from server "REMOTE" accepts last pending share                             # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                    # FederationContext::usingServer()
    And As an "user1"                                                                            # FederationContext::asAn()
[Fri Mar  8 13:36:06 2019] 127.0.0.1:42340 [200]: //ocs-provider/
[Fri Mar  8 13:36:06 2019] 127.0.0.1:42342 [200]: //status.php
[Fri Mar  8 13:36:06 2019] 127.0.0.1:42348 [200]: //status.php
[Fri Mar  8 13:36:07 2019] 127.0.0.1:42350 [200]: /index.php/apps/files_sharing/shareinfo?t=Uvj3awkxJ8qYCEC
[Fri Mar  8 13:36:07 2019] Undefined index: size at /drone/src/github.com/nextcloud/server/lib/private/Files/View.php#1324
[Fri Mar  8 13:36:07 2019] Undefined index: storage_mtime at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#126
[Fri Mar  8 13:36:07 2019] 127.0.0.1:42352 [401]: /public.php/webdav/
[Fri Mar  8 13:36:07 2019] 127.0.0.1:42356 [207]: /public.php/webdav/
[Fri Mar  8 13:36:07 2019] Undefined index: etag at /drone/src/github.com/nextcloud/server/lib/private/Files/Storage/DAV.php#784
[Fri Mar  8 13:36:07 2019] 127.0.0.1:42360 [200]: //status.php
[Fri Mar  8 13:36:07 2019] 127.0.0.1:42364 [200]: //status.php
[Fri Mar  8 13:36:07 2019] 127.0.0.1:42368 [200]: /index.php/apps/files_sharing/shareinfo?t=Uvj3awkxJ8qYCEC
[Fri Mar  8 13:36:07 2019] Undefined index: mimetype at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#108
[Fri Mar  8 13:36:07 2019] 127.0.0.1:50696 [404]: /remote.php/webdav/PARENT%20(2)/textfile0.txt-chunking-42-3-0
    And user "user1" uploads chunk file "1" of "3" with "AAAAA" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
      Client error: `PUT http://localhost:8180/remote.php/webdav/PARENT%20(2)/textfile0.txt-chunking-42-3-0` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And user "user1" uploads chunk file "2" of "3" with "BBBBB" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    And user "user1" uploads chunk file "3" of "3" with "CCCCC" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    When Downloading file "/PARENT (2)/textfile0.txt" with range "bytes=3-13"                    # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "AABBBBBCCCC"                                              # FederationContext::downloadedContentShouldBe()
[Fri Mar  8 13:36:07 2019] 127.0.0.1:42374 [200]: /ocs/v1.php/cloud/users/user0
[Fri Mar  8 13:36:07 2019] 127.0.0.1:42400 [404]: /ocs/v2.php/cloud/users/user0
[Fri Mar  8 13:36:08 2019] 127.0.0.1:42452 [200]: //ocm-provider/
[Fri Mar  8 13:36:08 2019] 127.0.0.1:42456 [400]: /index.php/ocm/notifications
[Fri Mar  8 13:36:08 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 12"}

TESTS=integration-sharing-v1

  • build/integration/features/sharing-v1.feature:58
Show full log 
  Scenario: Creating a new public share                    # /drone/src/github.com/nextcloud/server/build/integration/features/sharing-v1.feature:58
[Fri Mar  8 13:35:41 2019] 127.0.0.1:45138 [404]: /ocs/v2.php/cloud/users/user0
[Fri Mar  8 13:35:41 2019] 127.0.0.1:45146 [200]: /ocs/v1.php/cloud/users
[Fri Mar  8 13:35:42 2019] 127.0.0.1:45148 [200]: /ocs/v1.php/cloud/users/user0
[Fri Mar  8 13:35:42 2019] 127.0.0.1:45152 [200]: /ocs/v2.php/cloud/users/user0
    Given user "user0" exists                              # FeatureContext::assureUserExists()
    And As an "user0"                                      # FeatureContext::asAn()
[Fri Mar  8 13:35:42 2019] 127.0.0.1:45158 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    When creating a share with                             # FeatureContext::creatingShare()
      | path      | welcome.txt |
      | shareType | 3           |
    Then the OCS status code should be "100"               # FeatureContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "200"               # FeatureContext::theHTTPStatusCodeShouldBe()
[Fri Mar  8 13:35:44 2019] 127.0.0.1:45160 [404]: /index.php/s/7mz4yoM2PNpkQdg/download
    And Public shared file "welcome.txt" can be downloaded # FeatureContext::checkPublicSharedFile()
      Client error: `GET http://localhost:8080/index.php/s/7mz4yoM2PNpkQdg/download` resulted in a `404 Not Found` response (GuzzleHttp\Exception\ClientException)
[Fri Mar  8 13:35:44 2019] 127.0.0.1:45228 [200]: /ocs/v1.php/cloud/users/user0
[Fri Mar  8 13:35:44 2019] 127.0.0.1:45254 [404]: /ocs/v2.php/cloud/users/user0
[Fri Mar  8 13:35:44 2019] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Fri Mar  8 13:35:44 2019] 127.0.0.1:45280 [401]: /remote.php/webdav/myFileToComment.txt
[Fri Mar  8 13:35:44 2019] 127.0.0.1:45282 [207]: /remote.php/dav/systemtags/
[Fri Mar  8 13:35:44 2019] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Fri Mar  8 13:35:44 2019] 127.0.0.1:45298 [401]: /remote.php/webdav/myFileToTag.txt
[Fri Mar  8 13:35:44 2019] 127.0.0.1:45304 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Fri Mar  8 13:35:44 2019] 127.0.0.1:45324 [404]: /remote.php/dav/calendars/admin/MyCalendar

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

  • tests/acceptance/features/app-files.feature:41
  • tests/acceptance/features/app-files.feature:97
Show full log 
  Scenario: viewing a favorite file in its folder shows the correct sidebar view # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:41
    Given I am logged in                                                         # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "other"                                      # FileListContext::iCreateANewFolderNamed()
    And I mark "other" as favorite                                               # FileListContext::iMarkAsFavorite()
    And I mark "welcome.txt" as favorite                                         # FileListContext::iMarkAsFavorite()
    And I see that "other" is marked as favorite                                 # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that "welcome.txt" is marked as favorite                           # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I open the "Favorites" section                                           # AppNavigationContext::iOpenTheSection()
    And I open the details view for "other"                                      # FileListContext::iOpenTheDetailsViewFor()
      Row for file other in file list could not be found after 100 seconds
      File actions menu button for file other in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that the details view is open                                      # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I see that the file name shown in the details view is "other"            # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
    When I view "welcome.txt" in folder                                          # FileListContext::iViewInFolder()
    Then I see that the current section is "All files"                           # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I see that the details view is open                                      # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I see that the file name shown in the details view is "welcome.txt"      # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
    When I open the details view for "other"                                     # FileListContext::iOpenTheDetailsViewFor()
    And I see that the file name shown in the details view is "other"            # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()

  Scenario: show favorites for a second time                          # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:97
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I open the "Favorites" section                                # AppNavigationContext::iOpenTheSection()
    And I see that the current section is "Favorites"                 # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I open the "All files" section                                # AppNavigationContext::iOpenTheSection()
    And I see that the current section is "All files"                 # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I mark "welcome.txt" as favorite                              # FileListContext::iMarkAsFavorite()
    When I open the "Favorites" section                               # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Favorites"                # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing-link

  • tests/acceptance/features/app-files-sharing-link.feature:3
  • tests/acceptance/features/app-files-sharing-link.feature:26
  • tests/acceptance/features/app-files-sharing-link.feature:40
  • tests/acceptance/features/app-files-sharing-link.feature:60
  • tests/acceptance/features/app-files-sharing-link.feature:81
  • tests/acceptance/features/app-files-sharing-link.feature:116
  • tests/acceptance/features/app-files-sharing-link.feature:128
  • tests/acceptance/features/app-files-sharing-link.feature:139
Show full log 
  Scenario: open the menu in a public shared link                   # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:3
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                          # FilesAppSharingContext::iShareTheLinkFor()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I open the Share menu                                       # PublicShareContext::iOpenTheShareMenu()
      Share menu button in Shared file page could not be found after 100 seconds (NoSuchElementException)
    Then I see that the Share menu is shown                         # PublicShareContext::iSeeThatTheShareMenuIsShown()

  Scenario: show download again in a public shared link             # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:26
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                          # FilesAppSharingContext::iShareTheLinkFor()
    And I set the download of the shared link as hidden             # FilesAppSharingContext::iSetTheDownloadOfTheSharedLinkAsHidden()
    And I set the download of the shared link as shown              # FilesAppSharingContext::iSetTheDownloadOfTheSharedLinkAsShown()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    Then I see that the download button is shown                    # PublicShareContext::iSeeThatTheDownloadButtonIsShown()
      The download button is not visible yet after 100 seconds
    And I open the Share menu                                       # PublicShareContext::iOpenTheShareMenu()
    And I see that the Share menu is shown                          # PublicShareContext::iSeeThatTheShareMenuIsShown()

  Scenario: creation is not possible by default in a public shared folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:40
    Given I act as John                                                   # ActorContext::iActAs()
    And I am logged in                                                    # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Shared folder"                       # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Shared folder"                              # FilesAppSharingContext::iShareTheLinkFor()
    And I write down the shared link                                      # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                    # ActorContext::iActAs()
    And I visit the shared link I wrote down                              # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down       # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I see that the file list is eventually loaded                     # FileListContext::iSeeThatTheFileListIsEventuallyLoaded()
    Then I see that it is not possible to create new files                # FileListContext::iSeeThatItIsNotPossibleToCreateNewFiles()
      Create menu button in file list could not be found (NoSuchElementException)

  Scenario: create folder in a public editable shared folder        # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:60
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Editable shared folder"        # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                    # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                       # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Editable shared folder"               # FilesAppSharingContext::iShareTheLinkFor()
    And I set the shared link as editable                           # FilesAppSharingContext::iSetTheSharedLinkAsEditable()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
      │ Copy link button in the details view in Files app could not be clicked
      │ Exception message: Element is no longer attached to the DOM
      │ For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
      │ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
      │ System info: host: '305d16d1d3fe', ip: '172.17.0.12', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-43-generic', java.version: '1.8.0_91'
      │ Driver info: driver.version: unknown
      │ Trying again
      │ 
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I create a new folder named "Subfolder"                     # FileListContext::iCreateANewFolderNamed()
      Create menu button in file list could not be found after 100 seconds (NoSuchElementException)
    Then I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: owner sees folder created in the public page of an editable shared folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:81
    Given I act as John                                                               # ActorContext::iActAs()
    And I am logged in                                                                # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Editable shared folder"                          # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                                      # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                         # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Editable shared folder"                                 # FilesAppSharingContext::iShareTheLinkFor()
    And I set the shared link as editable                                             # FilesAppSharingContext::iSetTheSharedLinkAsEditable()
    And I write down the shared link                                                  # FilesAppSharingContext::iWriteDownTheSharedLink()
    And I act as Jane                                                                 # ActorContext::iActAs()
    And I visit the shared link I wrote down                                          # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down                   # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I create a new folder named "Subfolder"                                       # FileListContext::iCreateANewFolderNamed()
      Create menu button in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that the file list contains a file named "Subfolder"                    # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as John                                                                # ActorContext::iActAs()
    And I enter in the folder named "Editable shared folder"                          # FileListContext::iEnterInTheFolderNamed()
    Then I see that the file list contains a file named "Subfolder"                   # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: access a shared link protected by password with a valid password                   # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:116
    Given I act as John                                                                        # ActorContext::iActAs()
    And I am logged in                                                                         # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt" protected by the password "abcdef"                  # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
    And I write down the shared link                                                           # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                                         # ActorContext::iActAs()
    And I visit the shared link I wrote down                                                   # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the Authenticate page for the shared link I wrote down  # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheSharedLinkIWroteDown()
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'http://acceptance-app-files-sharing-link/index.php/s/EG5eijWLsxMAAop/authenticate/showShare'
      +'http://acceptance-app-files-sharing-link/index.php/s/EG5eijWLsxMAAop'
    And I authenticate with password "abcdef"                                                  # PublicShareContext::iAuthenticateWithPassword()
    Then I see that the current page is the shared link I wrote down                           # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I see that the shared file preview shows the text "Welcome to your Nextcloud account!" # PublicShareContext::iSeeThatTheSharedFilePreviewShowsTheText()

  Scenario: access a shared link protected by password with an invalid password                # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:128
    Given I act as John                                                                        # ActorContext::iActAs()
    And I am logged in                                                                         # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt" protected by the password "abcdef"                  # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
    And I write down the shared link                                                           # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                                         # ActorContext::iActAs()
    And I visit the shared link I wrote down                                                   # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I authenticate with password "fedcba"                                                  # PublicShareContext::iAuthenticateWithPassword()
      Password field in Authenticate page could not be found after 100 seconds (NoSuchElementException)
    Then I see that the current page is the Authenticate page for the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheSharedLinkIWroteDown()
    And I see that a wrong password for the shared file message is shown                       # PublicShareContext::iSeeThatAWrongPasswordForTheSharedFileMessageIsShown()

  Scenario: access a direct download shared link protected by password with a valid password                  # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:139
    Given I act as John                                                                                       # ActorContext::iActAs()
    And I am logged in                                                                                        # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt" protected by the password "abcdef"                                 # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
    And I write down the shared link                                                                          # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                                                        # ActorContext::iActAs()
    And I visit the direct download shared link I wrote down                                                  # PublicShareContext::iVisitTheDirectDownloadSharedLinkIWroteDown()
    And I see that the current page is the Authenticate page for the direct download shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheDirectDownloadSharedLinkIWroteDown()
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'http://acceptance-app-files-sharing-link/index.php/s/YKo4op7biZC2Mst/authenticate/downloadShare'
      +'http://acceptance-app-files-sharing-link/index.php/s/YKo4op7biZC2Mst/download'
    And I authenticate with password "abcdef"                                                                 # PublicShareContext::iAuthenticateWithPassword()
    And I see that the current page is the Authenticate page for the direct download shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheDirectDownloadSharedLinkIWroteDown()

TESTS=acceptance, TESTS-ACCEPTANCE=login

  • tests/acceptance/features/login.feature:9
  • tests/acceptance/features/login.feature:15
  • tests/acceptance/features/login.feature:26
  • tests/acceptance/features/login.feature:38
Show full log 
  Scenario: try to log in with valid user and invalid password # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:9
    Given I visit the Home page                                # FeatureContext::iVisitTheHomePage()
    When I log in with user user0 and password 654321          # LoginPageContext::iLogInWithUserAndPassword()
    Then I see that the current page is the Login page         # LoginPageContext::iSeeThatTheCurrentPageIsTheLoginPage()
    And I see that a wrong password message is shown           # LoginPageContext::iSeeThatAWrongPasswordMessageIsShown()
      Wrong password message in Login page could not be found after 100 seconds (NoSuchElementException)

  Scenario: log in with valid user and invalid password once fixed by admin # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:15
    Given I act as John                                                     # ActorContext::iActAs()
    And I can not log in with user user0 and password 654231                # LoginPageContext::iCanNotLogInWithUserAndPassword()
      Wrong password message in Login page could not be found after 100 seconds (NoSuchElementException)
    When I act as Jane                                                      # ActorContext::iActAs()
    And I am logged in as the admin                                         # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                            # SettingsMenuContext::iOpenTheUserSettings()
    And I set the password for user0 to 654321                              # UsersSettingsContext::iSetTheFieldForUserTo()
    And I act as John                                                       # ActorContext::iActAs()
    And I log in with user user0 and password 654321                        # LoginPageContext::iLogInWithUserAndPassword()
    Then I see that the current page is the Files app                       # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp()

  Scenario: try to log in with invalid user                    # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:26
    Given I visit the Home page                                # FeatureContext::iVisitTheHomePage()
    When I log in with user unknownUser and password 123456acb # LoginPageContext::iLogInWithUserAndPassword()
    Then I see that the current page is the Login page         # LoginPageContext::iSeeThatTheCurrentPageIsTheLoginPage()
    And I see that a wrong password message is shown           # LoginPageContext::iSeeThatAWrongPasswordMessageIsShown()
      Wrong password message in Login page could not be found after 100 seconds (NoSuchElementException)

  Scenario: log in with invalid user once fixed by admin              # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:38
    Given I act as John                                               # ActorContext::iActAs()
    And I can not log in with user unknownUser and password 123456acb # LoginPageContext::iCanNotLogInWithUserAndPassword()
      Wrong password message in Login page could not be found after 100 seconds (NoSuchElementException)
    When I act as Jane                                                # ActorContext::iActAs()
    And I am logged in as the admin                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I click the New user button                                   # UsersSettingsContext::iClickTheNewUserButton()
    And I see that the new user form is shown                         # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    And I create user unknownUser with password 123456acb             # UsersSettingsContext::iCreateUserWithPassword()
    And I see that the list of users contains the user unknownUser    # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I act as John                                                 # ActorContext::iActAs()
    And I log in with user unknownUser and password 123456acb         # LoginPageContext::iLogInWithUserAndPassword()

TESTS=acceptance, TESTS-ACCEPTANCE=users

  • tests/acceptance/features/users.feature:116
Show full log 
  Scenario: change display name                                        # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:116
    Given I act as Jane                                                # ActorContext::iActAs()
    And I am logged in as the admin                                    # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                       # SettingsMenuContext::iOpenTheUserSettings()
    And I see that the list of users contains the user user0           # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I see that the displayName of user0 is user0                   # UsersSettingsContext::iSeeThatTheFieldOfUserIs()
    When I set the displayName for user0 to user1                      # UsersSettingsContext::iSetTheFieldForUserTo()
    And I see that the displayName cell for user user0 is done loading # UsersSettingsContext::iSeeThatTheCellForUserIsDoneLoading()
    Then I see that the displayName of user0 is user1                  # UsersSettingsContext::iSeeThatTheFieldOfUserIs()
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'user0'
      +'user1'

@MorrisJobke MorrisJobke merged commit d40b21a into master Mar 8, 2019
@MorrisJobke MorrisJobke deleted the fix/noid/add-setup-check-for-s3-temp-path branch March 8, 2019 17:03
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 8, 2019

The backport to stable15 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 8, 2019

The backport to stable14 failed. Please do this backport manually.

SystemKeeper
SystemKeeper reviewed Mar 9, 2019
View reviewed changes
core/js/setupchecks.js
'core',
'This instance uses an S3 based object store as primary storage. The uploaded files are stored temporarily on the server and thus it is recommended to have 50 GB of free space available in the temp directory of PHP. Check the logs for full details about the path and the available space. To improve this please change the temporary directory in the php.ini or make more space available in that path.',
{
docLink: oc_defaults.docPlaceholderUrl.replace('PLACEHOLDER', 'admin-mysql-utf8mb4'),
Copy link
Contributor

@SystemKeeper SystemKeeper Mar 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MorrisJobke Is the docLink a copy&paste mistake? I don't see a placeholder in the message and linking to 'admin-mysql-utf8mb4' is obviously wrong in this case.

Copy link
Member Author

@MorrisJobke MorrisJobke Mar 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing - yes this is an c&p mistake.

Copy link
Member Author

@MorrisJobke MorrisJobke Mar 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the fix: #14620

@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 26, 2019

Backport together with #14620 once #14857 is in.

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 26, 2019

/backport to stable15

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 26, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 26, 2019

backport to stable15 in #14865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SystemKeeper SystemKeeper SystemKeeper left review comments

@rullzer rullzer rullzer approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@blizzz blizzz Awaiting requested review from blizzz

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: install and update

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke @rullzer @icewind1991 @SystemKeeper