Skip to content

Fix grid toggle button on public page#13514

Merged
MorrisJobke merged 1 commit intomasterfrom
fix-public-grid-toggle
Feb 25, 2019
Merged

Fix grid toggle button on public page#13514
MorrisJobke merged 1 commit intomasterfrom
fix-public-grid-toggle

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 11, 2019

Broken by #12385
Fix #13375

@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews regression labels Jan 11, 2019
@skjnldsv skjnldsv added this to the Nextcloud 16 milestone Jan 11, 2019
@skjnldsv skjnldsv self-assigned this Jan 11, 2019
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 11, 2019

/backport to stable15

This was referenced Jan 11, 2019
Merged
Closed
@jancborchardt
Copy link
Member

jancborchardt commented Jan 11, 2019

Please review @R0mannn @myevit @Bellusterra as it fixes the issue you reported at #13375 :)

@ChildLearningClub
Copy link

ChildLearningClub commented Jan 11, 2019 •
edited
Loading

Thank you @jancborchardt for the heads up and @skjnldsv for finding the issue.

juliusknorr
juliusknorr previously requested changes Jan 11, 2019
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to keep the check, otherwise we have the button on single file shares as well:

image

jancborchardt
jancborchardt previously requested changes Jan 11, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the button should not have the button style (background and border), just like when logged in. :)

@juliusknorr juliusknorr added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 14, 2019
@weeman1337
Copy link
Member

weeman1337 commented Jan 14, 2019

Since there are several issues with the grid button, maybe it makes sense to put some tests in for that!

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 14, 2019

@weeman1337 sure! Wanna help? :D

@weeman1337 weeman1337 mentioned this pull request Jan 15, 2019
Closed
@weeman1337
Copy link
Member

weeman1337 commented Jan 15, 2019

sure! Wanna help? :D

I knew that would come :) A ticket for me: #13613

@myevit
Copy link

myevit commented Jan 17, 2019

Hi guys, so sharing link though the gallery app has toggle button, once I press it it goes to file list and the button disappears

Also "Download" and "Download all files" :-)

https://victorsea.photography/nextcloud/index.php/apps/gallery/s/6iRrgxTNTmdF5eJ#
screen shot 2019-01-17 at 14 59 13
screen shot 2019-01-17 at 14 59 25

@skjnldsv
Fix grid toggle button on public page
ee2c45d 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix-public-grid-toggle branch from e3d4cb4 to ee2c45d Compare February 21, 2019 08:18
@skjnldsv skjnldsv dismissed stale reviews from juliusknorr and jancborchardt February 21, 2019 08:18

Done

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 21, 2019
@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 21, 2019

This one slipped through!
@nextcloud/designers please review!
@jancborchardt @juliushaertl please update 🙇‍♀️

jancborchardt
jancborchardt approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@skjnldsv skjnldsv requested a review from juliusknorr February 21, 2019 13:51
MorrisJobke
MorrisJobke approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit ee68e8f into master Feb 25, 2019
@MorrisJobke MorrisJobke deleted the fix-public-grid-toggle branch February 25, 2019 20:18
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 25, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Feb 25, 2019

backport to stable15 in #14376

@digitall-it
Copy link

digitall-it commented Jul 2, 2020 •
edited
Loading

Old behavior of the toggle was to change the URL on the top, so that it was possible to permalink to gallery view and the link to point to gallery view on page load. Latest versions of NextCloud do not allow that anymore because the toggle does not change add any URL fragment to account for that. Is there a way to at least manipulate the URL manually to achieve the same result? Tried on v18.0.6.

@PatriceVigier
Copy link

PatriceVigier commented Mar 13, 2021

It would be great to be able to decide how we want to share a folder, list or thumb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@weeman1337 weeman1337 Awaiting requested review from weeman1337

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: files feature: sharing regression

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

Add a thumbnail/grid view to folders shared via public link

9 participants

@skjnldsv @jancborchardt @ChildLearningClub @weeman1337 @myevit @digitall-it @PatriceVigier @MorrisJobke @juliusknorr