Skip to content

Do not load 2fa admin settings async#13489

Merged
rullzer merged 1 commit intomasterfrom
enh/settings/2fa-security-store
Feb 28, 2019
Merged

Do not load 2fa admin settings async#13489
rullzer merged 1 commit intomasterfrom
enh/settings/2fa-security-store

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Jan 10, 2019 •
edited
Loading

This makes sure the 2fa state is loaded directly instead of fireing off an async request showing a little spinner.

TODO:

  • use initial state
  • Save data via store?

@rullzer rullzer added this to the Nextcloud 16 milestone Jan 10, 2019
@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 28, 2019

You might want to use your new API from #13646 once it's merged ;)

@ChristophWurst
Copy link
Member

ChristophWurst commented Feb 26, 2019 

* Save data via store?

IMO unrelated -> setting to review

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 26, 2019
@rullzer
Copy link
Member Author

rullzer commented Feb 26, 2019

Lets do this then. Thnx @ChristophWurst

ChristophWurst
ChristophWurst approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for @rullzer's part

MorrisJobke
MorrisJobke reviewed Feb 27, 2019
View reviewed changes
MorrisJobke
MorrisJobke approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works (beside my little nitpick)

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 27, 2019
@rullzer rullzer force-pushed the enh/settings/2fa-security-store branch from da61d82 to 155d0c1 Compare February 28, 2019 09:26
@rullzer
Do not load 2fa admin settings async
c621da4 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the enh/settings/2fa-security-store branch from 155d0c1 to c621da4 Compare February 28, 2019 10:56
@rullzer rullzer merged commit a43ffc7 into master Feb 28, 2019
@rullzer rullzer deleted the enh/settings/2fa-security-store branch February 28, 2019 12:32
@ChristophWurst ChristophWurst mentioned this pull request Mar 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement javascript

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer @ChristophWurst @MorrisJobke