Take into account cropped layout setting#1659
Merged
Conversation
artonge
added
3. to review
artonge
force-pushed
the
artonge/fix/use_cropped_layout_info
branch
from
c3b04bc to
68fd74b
Compare
artonge
force-pushed
the
artonge/fix/use_cropped_layout_info
branch
from
68fd74b to
24fab37
Compare
ChristophWurst
approved these changes
Feb 27, 2023
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Code looks good!
Can't test because previews don't work on my dev env
skjnldsv
approved these changes
Feb 27, 2023
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/use_cropped_layout_info
branch
from
24fab37 to
d887817
Compare
Member
|
Would you consider this a fix and backportable? |
Collaborator
Author
|
/backport to stable25 |
backportbot-nextcloud
bot
added
the
backport-request
Collaborator
Author
|
Let's try :) |
1 task
backportbot-nextcloud
bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need a reload to be taken into account. But still better than nothing.