Tidy up to broad rename from location to place#1657
Merged
Conversation
artonge
added
bug
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/rename_to_place
branch
from
f7777f8 to
afb22c9
Compare
skjnldsv
approved these changes
Mar 1, 2023
skjnldsv
reviewed
Mar 1, 2023
| if ($node instanceof AlbumRoot) { | ||
| $propPatch->handle(self::LOCATION_PROPERTYNAME, function ($place) use ($node) { | ||
| $this->albumMapper->setLocation($node->getAlbum()->getAlbum()->getId(), $place); | ||
| $propPatch->handle(self::LOCATION_PROPERTYNAME, function ($location) use ($node) { |
Member
There was a problem hiding this comment.
I see no front change for the dav property, was it still using the old nc:location ?
@artonge
Member
There was a problem hiding this comment.
Nice, wanted to double check :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #1334