feat(api): Add context parameter to generate and validate endpoints #896
+48
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API endpoints now accept a 'context' parameter to specify which password policy set to use (account or sharing). This allows the files_sharing app to generate and validate passwords against the share-specific password policy instead of the default account policy. Fixes: #870 Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/share-password-policy-generation
branch
from
c464284 to
d4a04f3
Compare
nfebe
requested review from
nickvergessen and
susnux
and removed request for
susnux
susnux
reviewed
Feb 10, 2026
|
|
||
| /** | ||
| * Get a PasswordContext enum from a string | ||
| * @since 3.0.0 |
Contributor
There was a problem hiding this comment.
Suggested change
| * @since 3.0.0 | |
| * @since 6.0.0 |
susnux
approved these changes
Feb 10, 2026
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
just the version - otherwise fine!
nickvergessen
approved these changes
Feb 11, 2026
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Was about to send the same PR as Talk iOS implemented it and we noticed they can't specify the context.
So backporting would be appreciated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API endpoints now accept a 'context' parameter to specify which password policy set to use (account or sharing). This allows the files_sharing app to generate and validate passwords against the share-specific password policy instead of the default account policy.
Fixes: #870