Use notification main link if no parameter has a link#883
Merged
ChristophWurst merged 1 commit intomasterfrom Mar 8, 2021
Merged
Use notification main link if no parameter has a link#883ChristophWurst merged 1 commit intomasterfrom
ChristophWurst merged 1 commit intomasterfrom
Conversation
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
nickvergessen
approved these changes
Mar 8, 2021
Member
nickvergessen
left a comment
There was a problem hiding this comment.
Look right, but didn't test
Member
|
And yeah they should be mutual exclusive to avoid nesting. |
Member
|
/backport to stable21 |
Member
|
/backport to stable20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe I didn't get it but if main notification link and rich parameter links are mutually exclusive (to avoid nested links I guess), there is a mistake here 😁.
If I indeed didn't get it, I can still testify: the main link is not used with a basic notification definition like: