Skip to content

Bump CKEditor to 27#4859

Merged
ChristophWurst merged 2 commits intomasterfrom
dependagreeta/npm_and_yarn/ckeditor27
Mar 30, 2021
Merged

Bump CKEditor to 27#4859
ChristophWurst merged 2 commits intomasterfrom
dependagreeta/npm_and_yarn/ckeditor27

Conversation

@GretaD
Copy link
Contributor

@GretaD GretaD commented Mar 29, 2021

Signed-off-by: GretaD gretadoci@gmail.com

@ChristophWurst
Copy link
Member

what version of npm do you use?

what is left before review?

@GretaD
Copy link
Contributor Author

GretaD commented Mar 30, 2021

what version of npm do you use?

6.14.4

what is left before review?

me making sure that -23.657 removals is alright i didnt do smth wrong

@ChristophWurst
Copy link
Member

I think the big diff is from npm 6 because the npm lockfile was previously written with v7 and they have switched the format

Signed-off-by: GretaD <gretadoci@gmail.com>
@GretaD GretaD force-pushed the dependagreeta/npm_and_yarn/ckeditor27 branch from 38bb8d5 to 7684f25 Compare March 30, 2021 14:01
@GretaD GretaD requested a review from ChristophWurst March 30, 2021 14:23
@GretaD GretaD marked this pull request as ready for review March 30, 2021 14:24
@GretaD GretaD added this to the v1.10.0 milestone Mar 30, 2021
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, didn't test

@GretaD GretaD force-pushed the dependagreeta/npm_and_yarn/ckeditor27 branch from 0a16e28 to 259655a Compare March 30, 2021 14:26
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0a16e28 was better

@GretaD GretaD force-pushed the dependagreeta/npm_and_yarn/ckeditor27 branch 5 times, most recently from 966bc89 to 0d817c1 Compare March 30, 2021 15:33
Signed-off-by: GretaD <gretadoci@gmail.com>
@GretaD GretaD force-pushed the dependagreeta/npm_and_yarn/ckeditor27 branch from 0d817c1 to c244084 Compare March 30, 2021 15:37
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants