Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 24, 2025

You can have multiple folders with the same name
You can also have many of those same names nested into other sub-groupfolders.
Example:

├── TeamFolder1
│   ├── TeamFolder1
│   ├── TeamFolder2
│   ├── TeamFolder3
│   ├── TeamFolder4
│   └── TeamFolder5
└── TeamFolder2
    ├── TeamFolder1
    ├── TeamFolder2
    ├── TeamFolder3
    ├── TeamFolder4
    └── TeamFolder5

Resolution:

  1. We now only show top-level groupfolders, as clicking one will show the children anyway
  2. We now group them by source name, and use the groupfolder ID instead of the mountpoint to generate their source. Making them truly unique

@skjnldsv skjnldsv added bug 3. to review Items that need to be reviewed labels Apr 24, 2025
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Apr 24, 2025
@skjnldsv skjnldsv self-assigned this Apr 24, 2025
@provokateurin
Copy link
Member

I get the idea, but a frontend only fix is probably not enough. We also need to fix it in some way for the clients and they should all have the same experience, so a backend fix seems like a much better solution.

@skjnldsv
Copy link
Member Author

@provokateurin yes and no, there are multiple endpoints used here.
This one is the dedicated groupfolder listing endpoint, so a fix on the front is actually needed anyway.

Also, while I agree we need a backend fix, I cannot wait for a deeper refactor of our code.
Mitigating the issue is the priority

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/groupfolder-nest-overlap branch from c163c66 to b54ccb6 Compare April 24, 2025 14:06
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 8b76d5c into master Apr 29, 2025
50 checks passed
@skjnldsv skjnldsv deleted the fix/groupfolder-nest-overlap branch April 29, 2025 07:56
@skjnldsv skjnldsv mentioned this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Items that need to be reviewed bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants